ayecode / wp-super-duper Goto Github PK

in _my_extra_arguments

You have $options['block-output']['element::p']['content']

which fails with Notice: Undefined index: element::p in /var/www/html/.. /includes/vendor/ayecode/wp-super-duper/hello-world.php on line 131 ( add filter un commented ) (PHP 7.3 )

Now I'm not super advanced with PHP but I have never seen this syntax used in an array key element::p

I get what is trying to be done - i.e. update the content associated with the element type of p

But it seems to fail.

This project needs some code style as it is now it is very dramatic with mixed rules.

This class is almost approaching 3000 lines of code. It might be time to finally divide it into several classes.

I am maintainer of https://github.com/WPBP/Widgets-Helper that has a lot of features like more fields and custom callbacks for validations.

I guess that port those there can be helpful.

I've been lurking/following this class for a while and gave it a try today. Thanks for sharing! It's pretty straightforward and cool but I'm wondering if there is any official documentation that I missed? I've just been digging through the code and the examples.

My biggest concern is over a block preview in the editor. Is it not currently setup to have a preview? I'm wonder if thing widget_ops output argument can take a callback/function so we can return the actual block content in the editor as well?

Looks like we should cache the results on the page per CPT?
Ping me if you need help.

🎉

The idea is to add a new field to a block that will allow the user to select multiple condition for visibility, very much like our GD custom field conditions.

This will be a SD argument for anew field, it will display something like a button and current conditions below it. The button will open a modal where the conditions and be added or edited. The data will be stored in a JSON type array in a single field. Please look at how I did the blockstrap pluign gallery block.

1. Only for blocks.
2. Added by adding a field argument to a block, just change the "type" to something like "visibility_conditions".
3. Clicking the button opens the modal when it will have a conditions builder almost exactly like our GD field conditions inputs, though we will add some more options like user role etc.
4. Save as JSON type array, check how I did gallery images widget in blockstrap.
5. Implement a function that can be implemented to check the conditions and not output.
6. In the popup add and option for what should happen if condition met.
   1. No output.
   2. Show simple message, tex input and select if it should be a info/warning/danger notification.
   3. Show page content from ID
   4. Show a template part.

Have you considered types such as radio button and also toggles ( like advanced fie true / false ?

Should support a 'require_login' argument that displays a UWP (if available) login form to logged out users. Otherwise, just show a "you are required to login to view this section". This will save us a lot of time when implementing blocks.

Getting a bunch of notices that wp_add_inline_style and wp_add_inline_script are being called incorrectly from line 78.

Solved it by moving those to their own function, and then putting the hook there instead (ie how the other scripts and styles are enqueued in that section).

Didn't want to overstep, so I'm not submitting a PR, but the error-free code looks like this:

if ( ! $sd_widget_scripts ) {
    add_action('admin_enqueue_scripts', array( $this, 'enqueue_inline_scripts') );

   $sd_widget_scripts = true;

[truncated]

protected function enqueue_inline_scripts() {
    wp_add_inline_script( 'admin-widgets', $this->widget_js() );
    wp_add_inline_script( 'customize-controls', $this->widget_js() );
    wp_add_inline_style( 'widgets', $this->widget_css() );
}

https://github.com/AyeCode/wp-super-duper/blob/master/wp-super-duper.php#L1786

This is a tough one, spend a few hours on it but if you can't resolve let me know.

Currently, legacy widgets display alongside blocks when editing a widget area.

Proposed solution:-

For users using Gutenberg to edit widget areas, auto-convert existing widgets to blocks then hide legacy widgets on the widgets edit screen. We ONLY hide on the widgets edit screen so as to support Elementor and other page builders that use legacy widgets.

The goal for v2 is to lower memory usage and have everything run more efficiently.

• Split into multiple classes
• add an argument that can limit what is created, 'output_types' => array( 'block', 'shortcode'), by default it should load all 3.
• Add a settings screen to the WP Settings page so that users can globally disable loading as widgets.

For the last option, I think we should give it 3 options "Auto", "Active", "Disable".
When in auto we should try and check a few things to see if widget functionality is needed. For example;

• If no active old style widgets

• Check if any builders are active, eg; Elementor we use widgets so we would need to keep it active in that case.

• Add ability to convert current widget to blocks.
  Hopefully this is as simple as it looks, https://developer.wordpress.org/block-editor/how-to-guides/widgets/legacy-widget-block/#2-add-a-block-transform
  Hopefully we don't have to enable it in rest API, but if we do lets make it temporary.

• Hide widgets from legacy selector
  https://developer.wordpress.org/block-editor/how-to-guides/widgets/legacy-widget-block/#3-hide-the-widget-from-the-legacy-widget-block

• Add option to enable/disable legacy widgets.

<?php if ( $multiple ) { echo "multiple"; } //@todo not implemented yet due to gutenberg not supporting it

Categories and tags are supported in Gutenberg - so can this mechanism not be used. Multi select is very useful for many complex situations like a blaock that needs to pick cpts from by taxonomy or status

If the users has the block editor active for widgets they are seeing double GD widgets because it shows widgets and blocks

Since updating to WP 5.5, blocks (and widgets) created with WP Super Duper do not show up in the block inserter.
Nothing in the error log, so I'm not sure how to debug...