axoniq / axoniq-axonhub-client Goto Github PK

Upgrade com.fasterxml.jackson.core:jackson-databind to version 2.9.5 or later.

It used to be the case (and this is also in the manual) that axoniq.axonhub.componentname would default to spring.application.name.

I've observed this on client 1.1 and 1.1.1. Running on Spring Boot 2.0.5.

Currently working around this by explicitly setting

axoniq.axonhub.componentname=${spring.application.name}

Axon Server will become a more standard component in the Axon stack. Therefore, the Axon Client module should be part of the AxonFramework repository.

Hi,

I am working on implementing Opentracing in the Axonframework,
see this issue: (Which is also about sleuth, but the challenge is similar):

AxonFramework/AxonFramework#257

See also a discussion on opentracing-java regarding this very same issue:
opentracing/opentracing-java#318

See a log trace in the above issue, where we see a thread named ault-executor-0, which should really read grpc-default-executor-0 after this thread, opentracing will spin a new trace, likely because the spancontext is not propagated by the Grpc executor service.

My suspicion is that, the Trace context is not propagated by the NettyChannel when creating threads.
I noticed the PlatformConnectionManager, initialises a channel, with the default executor, and that it is also not possible to install custom Interceptors.

I would like to create a PR on the axonhub client, where (1) I use a context aware executor service, which could propagate the context and (2) install an opentracing interceptor

(1) This is a candidate Executor Service:

https://github.com/talsma-ict/context-propagation

(2) This is the candidate interceptor:

https://github.com/opentracing-contrib/java-grpc

Now, my question for now is, please provide guidance on how to contribute this and also, I can not build the project locally, as a private nexus is used, so how do I contribute to the Axonhub client?

Thank You,
Christophe Bouhier

We notice the configuration of the NettyChannelBuilder uses the default executor service.
It is advised to replace it with an executor service, and not use the default, as this will spin more threads when the number of channels grow.

Advise can be seen in i.e. here:
https://www.quora.com/What-are-some-tips-tricks-and-gotchas-when-using-gRPC

We don't have access to the server side code, but wonder how the configuration of grpc is on the server side.

Too many locations where reconnect are triggered. Occurs in version 1.0.2 of the client.