Support removal of debug logging calls from builds about axmol

[halx99]

#    define AXLOG(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGERROR(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGINFO(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGWARN(...) __AXLOGWITHFUNCTION(__VA_ARGS__)

they are present only for compatibility purpose, and DEPRECATED.

relative PR: #2017

[smilediver]

I think logging should be removed in release builds by default with an optional opt-in. One way would be to add AX_USE_LOGGING CMake option and something like:

#if !defined(AX_USE_LOGGING)
    #if _AX_DEBUG > 0
        #define AX_USE_LOGGING 1
    #endif
#endif

Ignoring the default values I recommend using enabling logic like AX_USE_LOGGING instead of the disabling like AX_STRIP_DEBUG_LOGGING to avoid double negatives.

Btw, it's possible to workaround this by setting custom null logger using setLogOutput()

[rh101]

Btw, it's possible to workaround this by setting custom null logger using setLogOutput()

That won't work in this case, since we still need output from AXLOGI/AXOGW/AXLOGE in release builds (depending on the output level set), and I don't want the debug logging calls to remain in the output executable.

I'll sort out a PR for this in the next few days.

[smilediver]

Ah, I missed that you're talking specifically about debug and verbose levels only...

Btw, just found that there are more of these:

#    define AXLOG(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGERROR(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGINFO(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGWARN(...) __AXLOGWITHFUNCTION(__VA_ARGS__)

Is there a reason why they don't use AXLOG_WITH_LEVEL()? And now they are inconsistent with AXLOGX() macros in respect of what gets enabled for debug/release builds.

[rh101]

Is there a reason why they don't use AXLOG_WITH_LEVEL()? And now they are inconsistent with AXLOGX() macros in respect of what gets enabled for debug/release builds.

I don't know why they were left in there as they are, but perhaps @halx99 can provide an answer to that question.

[halx99]

#    define AXLOG(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGERROR(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGINFO(format, ...) ax::print(format, ##__VA_ARGS__)
#    define AXLOGWARN(...) __AXLOGWITHFUNCTION(__VA_ARGS__)

they are present only for compatibility purpose, and DEPRECATED.