Comments (7)
Thanks for reporting this.
It looks like this is caused by the intersection between the boto3 BatchWriter
and our EncryptedClient
(for my future reference: [1][2][3]).
We look for the reserved attributes to attempt to keep the user from accidentally using those attributes for other things or re-encrypting items (exactly what is happening here).
I think that a reasonable balance here might be to add a check into the encrypt_batch_write_item
to determine whether the item was already encrypted. We will want to do what we can to make sure that the item was actually encrypted by this client and was not since modified.
[1] https://github.com/boto/boto3/blob/develop/boto3/dynamodb/table.py#L133-L147
[2] https://github.com/aws/aws-dynamodb-encryption-python/blob/master/src/dynamodb_encryption_sdk/internal/utils.py#L270-L298
[3] https://github.com/aws/aws-dynamodb-encryption-python/blob/master/src/dynamodb_encryption_sdk/encrypted/item.py#L67-L71
from aws-dynamodb-encryption-python.
We will be addressing this in #92
from aws-dynamodb-encryption-python.
Hey @mattsb42-aws any idea when this might get into an official release?
from aws-dynamodb-encryption-python.
Hi @woodyza. Sorry, this fell through the cracks.
Since this changes the API behavior, this is going to need to be a minor-version change. Because of that I had wanted to get the change to address #90 in that release as well, but have had other things that kept taking priority.
However, after taking another look through #90, I realize now that we cannot process that silently like we could the batch operations (detailed update in that issue).
I have a couple minor linting issues that I need to address (pylint update, I think), but after that we should be good to publish. I'll update here once a new version is pushed.
from aws-dynamodb-encryption-python.
All good, thanks for the update! 👍
from aws-dynamodb-encryption-python.
@woodyza 1.1.0
is now live with these changes.
from aws-dynamodb-encryption-python.
Great stuff, thank you!
from aws-dynamodb-encryption-python.
Related Issues (20)
- downstream tests in upstream library failing but upstream tests passing HOT 1
- AwsKmsCryptographicMaterialsProvider - __attrs_post_init__ overrides custom regional clients HOT 2
- Creation of regional clients modifies default botocore session's region
- Add repr=False to attributes in EncryptionContext
- Unable to use dynamodb-encryption-sdk as layer HOT 5
- CPython 3.4 support HOT 1
- Migrate CI/CD to GitHub Actions
- aws_kms_encrypted_table.py giving "Failed to generate materials using AWS KMS" HOT 4
- what should the metastore do if the material type version is not present?
- refine hypothesis strategies
- Invalid transformation format:AES/256/CBC/PKCS5Padding : Interoperabilty between Python and Java SDKs HOT 3
- Add Attested Materials provider HOT 2
- AwsKmsCryptographicMaterialsProvider Design/Behavior Improvements HOT 3
- Upgrading "Do Nothing" model to one with a single action fails to decrypt old items
- Compatibility with AWS' automatic KMS key rotation? HOT 2
- Getting null values in `desc` and `sign` fields when I fetch the item using get_item function in boto3 HOT 2
- Support transactional methods in EncryptionClient HOT 2
- Wrong formatting in the deprecated python warning HOT 3
- typehints and imports HOT 2
- /lib64/libc.so.6: version `GLIBC_2.28' not found (required by /var/task/cryptography/hazmat/bindings/_rust.abi3.so)" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-dynamodb-encryption-python.