aws-cloudformation / aws-cloudformation-resource-providers-macie

CloudFormation Resource Provider Package For Amazon Macie

This repository contains AWS-owned resource providers for the AWS::Macie::* namespace.

License

This project is licensed under the Apache-2.0 License.

aws-cloudformation-resource-providers-macie's Issues

Incorrect values of additionalIdentifiers

Syntax definition of additionalIdentifiers is incorrect :
current

"additionalIdentifiers": [
    [
      "/properties/Arn"
    ],
    [
      "/properties/Name"
    ]
  ],

This needs to be just list of string , for example -

   "additionalIdentifiers": [
        "/properties/Arn",
        "/properties/Name"
    ]

Resource semantics :
additionalIdentifiers: Each property listed in the additionalIdentifiers section must be able to be used to uniquely identify the resource. These properties can be independently provided as keys to a READ or DELETE request and MUST be supported as the only input to those operations. These properties are usually also marked as readOnlyProperties and MUST be returned from READ and LIST operations. A provider is not required to support additionalIdentifiers; doing so allows for other unique keys to be used to READ resources.

[AWS::Macie::FindingsFilter] ListHandler should not use proxy chain

opening this for discussion.

Using call chain in ListHandler.java might be an issue in case the resource isn't singleton. Call chain registers all requests/responses so in case of having many resources under account might cause cw exceed limit exception

Maven build failing: incompatible types

2021-02-06T00:22:37.6605617Z [ERROR] /home/runner/work/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java:[99,44] incompatible types: java.lang.Long cannot be converted to java.lang.Integer
2021-02-06T00:22:37.6620602Z [ERROR] /home/runner/work/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java:[98,42] incompatible types: java.lang.Long cannot be converted to java.lang.Integer
2021-02-06T00:22:37.6635477Z [ERROR] /home/runner/work/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java:[97,44] incompatible types: java.lang.Long cannot be converted to java.lang.Integer
2021-02-06T00:22:37.6650095Z [ERROR] /home/runner/work/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java:[96,42] incompatible types: java.lang.Long cannot be converted to java.lang.Integer
2021-02-06T00:22:37.6664770Z [ERROR] /home/runner/work/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers/aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java:[119,33] incompatible types: java.lang.Integer cannot be converted to java.lang.Long

aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java

Lines 96 to 99 in aa6d4a8

	.gt(getLongOrNull(input.getGt()))
	.gte(getLongOrNull(input.getGte()))
	.lt(getLongOrNull(input.getLt()))
	.lte(getLongOrNull(input.getLte()))

aws-cloudformation-resource-providers-macie/aws-macie-findingsfilter/src/main/java/software/amazon/macie/findingsfilter/BaseMacieFindingFilterHandler.java

Line 119 in aa6d4a8

.gt(getIntegerOrNull(criterionAdditionalProperties.gt()))