awesome-webextension / webextension-store-meta Goto Github PK

I added ES-module support for typescript support. It's outdated, but it worked, but I don't really know what I'm doing, so I didn't feel confident to open a PR, here's the code: https://github.com/cachho/webextension-store-meta

Now, with the breaking changes, I know that from my last attempt that I rather not do it again, so with this issue I'm asking if anyone could at typescript support. Thank you.

Hi there 👋 We've run into an issue with this package in Shields.io because after updating some other dependencies in our tree (refs badges/shields#6611) domutils is now getting resolved to v2. domutils is an indirect dependency in our tree, and from what I can tell a direct, but undeclared, dependency here in webextension-store-meta.

Error snippet included below for reference, let me know if you have any questions or need any more information!

Error: Cannot find module 'domutils/lib/tagtypes'
Require stack:
- /home/circleci/project/node_modules/webextension-store-meta/lib/dom.js
- /home/circleci/project/node_modules/webextension-store-meta/lib/chrome-web-store/index.js
- /home/circleci/project/services/chrome-web-store/chrome-web-store-base.js
- /home/circleci/project/services/chrome-web-store/chrome-web-store-price.service.js
- /home/circleci/project/core/base-service/loader.js
- /home/circleci/project/core/base-service/loader.spec.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (node_modules/webextension-store-meta/lib/dom.js:1:36)
    ```

Hello.

Recently all our calls via this lib are failing with FetchError: maximum redirect reached

Example failing code:

import ChromeWebStore from 'webextension-store-meta/lib/chrome-web-store/index.js'

await ChromeWebStore.load({ id: 'iocghaljaochhkgajdilelogdkejkiil' })

ref: badges/shields#10094

Currently shields.io use this library like this:

import ChromeWebStore from 'webextension-store-meta/lib/chrome-web-store/index.js'
...
async fetch({ storeId }) {
    return await ChromeWebStore.load({ id: storeId })
    ...
}

However, console.log(ChromeWebStore) for v1.2.1 now gives us:

{
  ChromeWebStore: [class ChromeWebStore],
  default: [class ChromeWebStore]
}

Therefore it crashes with TypeError: ChromeWebStore.load is not a function.

badgen uses this library in a similar manner, which would also crash (but I haven't tested).