auxmoney / opentracingbundle-guzzle Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 5.0 215 KB

Guzzle extension for the auxmoney/OpentracingBundle-core

License: MIT License

PHP 96.63% Shell 3.37%

auxmoney opentracing opentracing-bundle symfony symfony-bundle distributed-tracing guzzle guzzlehttp

opentracingbundle-guzzle's People

Contributors

Stargazers

Watchers

Forkers

vincentlemaireagriconomie eddycharly thinhqt ict-works aboutcoders

opentracingbundle-guzzle's Issues

[Scrutinizer] unused parameter

see https://scrutinizer-ci.com/g/auxmoney/OpentracingBundle-Guzzle/issues/master/files/Tests/Middleware/GuzzleTracingHeaderInjectionTest.php?orderField=path&order=asc&honorSelectedPaths=0&issueId=42657419#inspectioncomment-148581271

EightPointsGuzzleBundle support

Within https://github.com/8p/EightPointsGuzzleBundle the handlers are services by themself. The Client doesn't seem to get registred.

id: eight_points_guzzle.handler_stack.
class: GuzzleHttp\HandlerStack

I would suggest the following change:

if ($definition->getClass() === Client::class) {
    $this->addMiddlewareToHandlerStack($container, $definition, $clientServiceName);
} elseif () {
    $definition->addMethodCall('push', [new Reference(GuzzleRequestSpanning::class)]);
    $definition->addMethodCall('push', [new Reference(GuzzleTracingHeaderInjection::class)]);
}

support Guzzle 7

We should check the upgrade guide and enable the plugin to work with Guzzle v7.

add automatic spanning of Guzzle callouts

In order to save manual implementation overhead for each bundle user, we would like to automatically generate spans for Guzzle requests, exactly like auxmoney/OpentracingBundle-core#2 .

Promise interface, onRejected ?

In GuzzleRequestSpanning, isn't the $onRejected callback missing ?

OpentracingBundle-Guzzle/Middleware/GuzzleRequestSpanning.php

Lines 31 to 37 in ced155c

    
           return $promise->then( 
        
               function (ResponseInterface $response) { 
        
                   $this->requestSpanning->finish($response->getStatusCode()); 
        
                   $this->tracing->finishActiveSpan(); 
        
                   return $response; 
        
               } 
        
           );

See the relevant interface here:
https://github.com/guzzle/promises/blob/89b1a76b7fda5853401297dc4b2a093cba1fda23/src/PromiseInterface.php#L28-L31

I fear that if the request is canceled or in case of an error, the open span won't be closed.

Not working with factory ?

We have a factory that creates a guzzle client, this factory returns the guzzle client with a handler created given some arguments.

The service looks like this:

    admin.microservice.client:
        class: GuzzleHttp\Client
        factory: [\Agriconomie\Microservice\ClientFactory, create]
        arguments:
            $debug: '%kernel.debug%'
            $logger: '@monolog.logger.internal_api'

And the factory:

    /**
     * @param bool $debug
     * @param LoggerInterface|null $logger
     */
    public static function create(bool $debug, ?LoggerInterface $logger) {
        $handlerStack = HandlerStack::create();
        $client = new \GuzzleHttp\Client([
            'handler' => $handlerStack
        ]);
        if (null !== $logger) {
            $handlerStack->push(Middleware::log($logger, new MessageFormatter(MessageFormatter::SHORT), LogLevel::INFO));
            if ($debug) {
                $handlerStack->push(Middleware::log($logger, new MessageFormatter(MessageFormatter::DEBUG), LogLevel::DEBUG));
            }
        }
        return $client;
    }

I integrated the opentracing guzzle bundle, it breaks here i think:

OpentracingBundle-Guzzle/DependencyInjection/GuzzleHandlerStackCompilerPass.php

Lines 24 to 30 in ced155c

    
           foreach ($container->getDefinitions() as $clientServiceName => $definition) { 
        
               if ($definition->getClass() === Client::class) { 
        
                   $this->addMiddlewareToClient($container, $definition, $clientServiceName); 
        
               } elseif ($definition->getClass() === HandlerStack::class) { 
        
                   $this->addUniqueMethodCallsToHandlerStack($definition); 
        
               } 
        
           }

probably because of this:

OpentracingBundle-Guzzle/DependencyInjection/GuzzleHandlerStackCompilerPass.php

Lines 58 to 70 in ced155c

    
           private function getConfiguration(Definition $definition): array 
        
           { 
        
               $arguments = $definition->getArguments(); 
        
               $configuration = []; 
        
               if (isset($arguments[0])) { 
        
                   $configuration = $arguments[0]; 
        
               } elseif (isset($arguments['$config'])) { 
        
                   $configuration = $arguments['$config']; 
        
               } 
        
               return $configuration; 
        
           }

Shouldn't the process method take care of the factory use case ?

Thanks.

auxmoney / opentracingbundle-guzzle Goto Github PK

opentracingbundle-guzzle's People

Contributors

Stargazers

Watchers

Forkers

opentracingbundle-guzzle's Issues

[Scrutinizer] unused parameter

EightPointsGuzzleBundle support

support Guzzle 7

add automatic spanning of Guzzle callouts

Promise interface, onRejected ?

Not working with factory ?

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	return $promise->then(
	function (ResponseInterface $response) {
	$this->requestSpanning->finish($response->getStatusCode());
	$this->tracing->finishActiveSpan();
	return $response;
	}
	);

	foreach ($container->getDefinitions() as $clientServiceName => $definition) {
	if ($definition->getClass() === Client::class) {
	$this->addMiddlewareToClient($container, $definition, $clientServiceName);
	} elseif ($definition->getClass() === HandlerStack::class) {
	$this->addUniqueMethodCallsToHandlerStack($definition);
	}
	}

	private function getConfiguration(Definition $definition): array
	{
	$arguments = $definition->getArguments();

	$configuration = [];
	if (isset($arguments[0])) {
	$configuration = $arguments[0];
	} elseif (isset($arguments['$config'])) {
	$configuration = $arguments['$config'];
	}

	return $configuration;
	}