Coder Social home page Coder Social logo

autonome / alwaysright Goto Github PK

View Code? Open in Web Editor NEW
26.0 26.0 5.0 202 KB

Browser extension that always opens new tabs immediately to the right of the active tab.

Home Page: https://addons.mozilla.org/en-us/firefox/addon/always-right/

JavaScript 100.00%

alwaysright's People

Contributors

autonome avatar cpeterso avatar rob--w avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

alwaysright's Issues

New tabs not Always Right

Hi folks,
Always Right has been working fine for months. But in the past few days, Firefox is opening new tabs last, instead of right next to the active tab. It's as if Always Right is disabled - but it's not. It's enabled. I've tried rebooting Firefox v59.0a couple of times, and rebooting my MacBook Pro (running 10.10.5). Still didn't fix.

Finally removed and reinstalled it, which fixed it. Just letting you know.

ff `browser.tabs.insertAfterCurrent` setting

Recent version of firefox (71, possibly earlier too) has browser.tabs.insertAfterCurrent setting which can be set to True to open new tabs on the right, rather than browser.browserSettings.newTabPosition

New tabs from the same domain name don't always open to the right

Hello. Let's say there are 10 tabs with the same domain name (e.g. AndroidPolice dot com). The 4th tab from the left is on foreground. I find a link on that page, that's also from AndroidPolice, right click and open it in new tab. It doesn't always open next to the 4th tab. It's not easy to reproduce. It started happening few days ago. I'm using Windows 10, Firefox 57 Beta 64bit.
Could it be related to a change that was done to Firefox to fix this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1402205

Tab jumping into position

When opening a new tab, I can see it get open on the default spot and then it jumps to the right of my active tab.

Always Right opens new tab in wrong position after current tab is dragged to new position

STR:

  1. Open a new window.
  2. Open three new tabs.
  3. Select tab 1.
  4. Drag tab 1 to replace tab 3 position.
  5. Press Ctrl+T to open a new tab.

EXPECTED RESULT
The new tab should appear to the right of tab 3.

ACTUAL RESULT:
The new tab appears to the right of tab 1 because that was the old position of tab 3 before it was dragged. Always Right seems to only check the current tab position when the tab is selected, not when the new tab is opened.

I am using Always Right add-on version 1.6.1.

Not always right - see example in description below

Start from a web page ('Tab0') with several links on it. Open one of these links in a new tab ('Tab1') (in background, so focus stays on initial page). Then do same with another link on Tab0: the new tab, Tab2, opens to the right of Tab1, not of Tab0.

Behaviour continues if I open another link in background, it opens in Tab 3 to the right of Tab2, etc.

The behaviour I am looking for is that the last opened tab is indeed directly to the right of Tab0 (preferences might differ depending on user, so maybe that could be a user-configurable setting).

Instead it is as if the last created tab is considered as the active tab to the right of which the next opened tab should be placed, even though I am still on Tab0.

I use an add-on, Right Links WE, to open tabs from a link while staying on the page/tab on which that link is. I cannot say to what extent the behaviour results from this addon, I have not tried getting the same functionality by other means (e.g. modifying some about:config preferences).

Thanks if you have a chance to look into it.

2.0.4 not working after browser restart

Needed to do a Firefox refresh today so Always Right was updated to 2.0.4 but it does not open to the next right it goes to the extreme right which has been up to 70 tabs away. Previous version worked seamlessly.

Using Firefox 54.0.1 32 bit

Not functional in Nightly 53.0a1?

I've had great experiences in the past with this plugin (while also running Nightly), but recently it seems to have stopped working. Tabs just open to the far right in all cases. Has anyone else seen this behavior?

Firefox: 53.0a1 (2016-12-14) (64-bit)
OS: macOS 10.12.2 (16C67)

new tabs from middle-click or context menu open to the right of other newly added tabs from that method

Is this project dead? The last issue had no response and was the reason why I wanted to install this addon.

I want tab to open like before quantum ALWAYS to the right next to the current tab

Now newest tabs open the furthest away from the current tab. I always want the last tab to be the one closest to the active tab

So [Active tab] 3 2 1 instead of [Active tab] 1 2 3

Would that be possible? Otherwise I don't know what this add-on does when the preference open tabs next to current is enabled.

Remove `oldSchool` method to simplify?

browser.browserSettings.newTabPosition has been supported since FF 61. Current version is 76+.

Maybe we can remove the oldSchool method to simplify the extension? This also removes the need for the tabs permission.

I've simplified my clone of this repo and tested it in my browser. Happy to submit a PR if you think this is appropriate.

Signature issue

Good afternoon!

I install your extension by coping it to core\browser\extensions.

// Activate extensions in core
user_pref("extensions.autoDisableScopes", 11); // 15 - 4 = ALL - SCOPE_APPLICATION
user_pref("extensions.enabledScopes", 5); // 15 - 8 - 2 = ALL - SCOPE_SYSTEM - SCOPE_USER

And there is this error in Developer Edition v45
ar

Could you advise?

Add support for "newTabPosition" API

https://bugzilla.mozilla.org/show_bug.cgi?id=1344749 was fixed today; I'm wondering if this add-on should use the new API to control new tabs position.

This patch implements the preference "browser.tabs.insertAfterCurrent" which,
when set to true, will cause all tabs (related and unrelated) to be opened next
to the current tab.

It also implements the browserSettings API "newTabPosition", which allows
extensions to control both "browser.tabs.insertRelatedAfterCurrent", and
"browser.tabs.insertAfterCurrent" via values for "afterCurrent",
"relatedAfterCurrent" and "atEnd".

Fall back to front of the list

Hi! I've noticed that very occasionally a new tab gets opened at the end of my tab list. There is probably a bug somewhere but I haven't been able to reproduce it.

It made me wonder, could it fall back to the front of the list for any case where the rightmost-position can't be known? I think that more or less matches the use case for this extension, i.e. your last task is most likely at the front of the tab list.

Last Tab Moves To Position Two On Browser Restart

When I close Firefox, what was the last tab on the right moves to the second tab from the left when I re-open the browser.

I'm currently running version 56.0.2 (64-bit), but it was also happening with the previous version 56.0.1.

Any way to stop this from happening?

Thanks!

Always left on close

Please consider adding the complementing feature:
When closing a tab focus goes to the tab on the left.

Version 2.0.0 not working on Firefox 53.0.2 (64-bit), Windows 10

Thanks for your excellent work on this add-on, it allows such a great feature that I don't understand why Firefox doesn't have it as default.

I'm here to report that since the update to v2.0.0 the add-on is not working for me and another user (Tarabass) that left you a post at the Firefox Add-ons site (https://addons.mozilla.org/en-US/firefox/addon/always-right/). Both of us are working on Firefox 53.0.2 (64-bit), Windows 10. I don't know if that is just a coincidence or not.

For me, the issue is erratic: when I open a new tab by middle click on a link, sometimes the tab is opened at the end (far right) of the tab list, sometimes is opened just as expected, next to the current tab. This happens too when I open a new tab by CTRL+T hotkey.

Other issue that I have is that when I open a new tab by middle click, the tab list is scrolled to the beginning (far left) of the tab list, while the body of current tab is still showed. This issue doesn't happen as often as the previous issue.

Thanks! hope you can fix it. If you need another info from me, don't hesitate to ask ๐Ÿ‘

2.0 - New tab moves to the beginning of the visible tab bar

In the new WebExtension version, opening a new tab has the effect of moving the tab bar to the first position of the new tab.

For example, let's say tab 12 is the active tab:

| tab 10 | tab 11 | tab 12 (active) | tab 13 | tab 14... 30 |

If I open a new tab, then the tab bar becomes:

| tab 13 (new tab) | tab 14 | tab 15 | tab 16 | tab 17... 30 |

I much prefer the older XUL method of the tabbar not moving:

| tab 10 | tab 11 | tab 12 | tab 13 (new tab) | tab 14 | tab 15... 30 |

A similar addon has the same problem. This is probably a limitation of the new WebExtension API, but thought I'd post an issue about this.

Keep the original order for continuous background tabs

I like how this add-on prevent tabs from opening way at the end of the tab bar; but I also wish that the original order of new tabs would be respected too, i.e. new tab 1 should be inserted after current tab, and new tab 2 should be inserted after new tab 1 rather than before it. This is how Firefox normally handles opening new links. Can this be implemented? Most notably opening new bookmarks via toolbar does not use the original order with this add-on installed.

Inconsistent background tab placement

By default Firefox always opens links opened from the same tab in background (with a middle click or through a context menu โ†’ Open Link in New Tab) next to each other in the order of opening, until the user switches to another tab. So if my current tabs are [a] b with a active, and I open tabs 1 2 3 in that order, I'll get [a] 1 2 3 b. Similarly a [b] โ†’ a [b] 1 2 3. That's the default FF behavior since version 3.6.

Always Right preserves this very convenient behavior (and AFAICT is the only WE of its kind that does so) almost always except when opening links from the last tab :
[a] b โ†’ [a] 1 2 3 b
a [b] โ†’ a [b] 3 2 1
And this is rather buggy too: a [b] 3 2 1 is what I get if I open links fast enough, but if any of the opened bg tabs has time to load while I open other tabs, the add-on switches to the default ordering, which is very confusing:
a [b] โ†’ a [b] 3 4 5 2 1.

Here's how it looks:

2017-11-20_18-32-32

I would love if Always Right could always preserve the default FF behavior re: opening links in bg from the same tab no matter where or how fast they were opened.

FF57, fresh profile, no other extensions/settings.

add test harness

  1. write a list of all scenarios to test
  2. build harness to test those which are able to be tested from within the browser

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.