authorofthesurf / hyrule-atom Goto Github PK

Add them.

• function should be light green
• Some "special" functions are yellow, some are dark green. These should be consistently colored. Good idea to look at other color schemes that do this well.

Make further evaluations and tweaks after that.

Title. Currently comments are working, everything else is default white.

title, these are both keywords within comments and should be consistently colored along with any other TODO-like keywords.

e.g.

// FIXME: this logic should be improved!
if (x) { return true } else { return false } 

#7 was resolved by adding manual install details to the README. However a plan of action towards deployment to Atom should still be made. Here lies some steps for a quality initial release.

_copied todos into the PR at #11 _

With the new IDE features, Atom will often highlight sections of code on mouseover. Hyrule probably has no setting for this highlight class(?) so the default style is used. The whole section gets a "lovely" sky-blue background. Maybe there could be a more suitable color.

No, I do not know what class is applied to those highlighted sections.

Changes to be made that I come across as I am working

• JS - function to light green
• Java - @annotations to light green
• JSP - jsp tags to orange. Use more dark green and yellow to make this happen nicely.

In Hyrule-atom\index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor, :host => atom-text-editor,atom-text-editor
• atom-text-editor .wrap-guide, :host .wrap-guide => atom-text-editor .wrap-guide,atom-text-editor .wrap-guide
• atom-text-editor .indent-guide, :host .indent-guide => atom-text-editor .indent-guide,atom-text-editor .indent-guide
• atom-text-editor .invisible-character, :host .invisible-character => atom-text-editor .invisible-character,atom-text-editor .invisible-character
• atom-text-editor .gutter, :host .gutter => atom-text-editor .gutter,atom-text-editor .gutter
• atom-text-editor .gutter .line-number.cursor-line, :host .gutter .line-number.cursor-line => atom-text-editor .gutter .line-number.cursor-line,atom-text-editor .gutter .line-number.cursor-line
• atom-text-editor .gutter .line-number.cursor-line-no-selection, :host .gutter .line-number.cursor-line-no-selection => atom-text-editor .gutter .line-number.cursor-line-no-selection,atom-text-editor .gutter .line-number.cursor-line-no-selection
• atom-text-editor .gutter .line-number.folded, :host .gutter .line-number.folded, atom-text-editor .gutter .line-number:after, :host .gutter .line-number:after, atom-text-editor .fold-marker:after, :host .fold-marker:after => atom-text-editor .gutter .line-number.folded,atom-text-editor .gutter .line-number.folded, atom-text-editor .gutter .line-number:after,atom-text-editor .gutter .line-number:after, atom-text-editor .fold-marker:after,atom-text-editor .fold-marker:after
• atom-text-editor .invisible, :host .invisible => atom-text-editor .invisible,atom-text-editor .invisible
• atom-text-editor .cursor, :host .cursor => atom-text-editor .cursor,atom-text-editor .cursor
• atom-text-editor .selection .region, :host .selection .region => atom-text-editor .selection .region,atom-text-editor .selection .region
• atom-text-editor .search-results .marker .region, :host .search-results .marker .region => atom-text-editor .search-results .syntax--marker .region,atom-text-editor .search-results .syntax--marker .region
• atom-text-editor .search-results .marker.current-result .region, :host .search-results .marker.current-result .region => atom-text-editor .search-results .syntax--marker.current-result .region,atom-text-editor .search-results .syntax--marker.current-result .region
• .comment => .syntax--comment
• .keyword => .syntax--keyword
• .keyword.control => .syntax--keyword.syntax--control
• .keyword.operator => .syntax--keyword.syntax--operator
• .keyword.other.special-method => .syntax--keyword.syntax--other.syntax--special-method
• .keyword.other.unit => .syntax--keyword.syntax--other.syntax--unit
• .storage => .syntax--storage
• .storage.modifier => .syntax--storage.syntax--modifier
• .storage.modifier.js => .syntax--storage.syntax--modifier.syntax--js
• .storage.function.js, .storage.function.python => .syntax--storage.syntax--function.syntax--js, .syntax--storage.syntax--function.syntax--python
• .storage.type.variable.ruby => .syntax--storage.syntax--type.syntax--variable.syntax--ruby
• .storage.type.class => .syntax--storage.syntax--type.syntax--class
• .todo => .syntax--todo
• .fixme => .syntax--fixme
• .variable => .syntax--variable
• .variable.interpolation => .syntax--variable.syntax--interpolation
• .variable.parameter.function => .syntax--variable.syntax--parameter.syntax--function
• .constant => .syntax--constant
• .constant.character.escape => .syntax--constant.syntax--character.syntax--escape
• .constant.numeric => .syntax--constant.syntax--numeric
• .constant.other.color => .syntax--constant.syntax--other.syntax--color
• .constant.other.symbol => .syntax--constant.syntax--other.syntax--symbol
• .constant.other.placeholder => .syntax--constant.syntax--other.syntax--placeholder
• .invalid.illegal => .syntax--invalid.syntax--illegal
• .string => .syntax--string
• .string.regexp => .syntax--string.syntax--regexp
• .string.regexp .source.ruby.embedded => .syntax--string.syntax--regexp .syntax--source.syntax--ruby.syntax--embedded
• .string.other.link => .syntax--string.syntax--other.syntax--link
• .punctuation.definition.comment => .syntax--punctuation.syntax--definition.syntax--comment
• .punctuation.definition.string => .syntax--punctuation.syntax--definition.syntax--string
• .punctuation.definition.variable, .punctuation.definition.parameters, .punctuation.definition.array => .syntax--punctuation.syntax--definition.syntax--variable, .syntax--punctuation.syntax--definition.syntax--parameters, .syntax--punctuation.syntax--definition.syntax--array
• .punctuation.definition.heading, .punctuation.definition.identity => .syntax--punctuation.syntax--definition.syntax--heading, .syntax--punctuation.syntax--definition.syntax--identity
• .punctuation.definition.bold => .syntax--punctuation.syntax--definition.syntax--bold
• .punctuation.definition.italic => .syntax--punctuation.syntax--definition.syntax--italic
• .punctuation.definition.tag => .syntax--punctuation.syntax--definition.syntax--tag
• .punctuation.definition.tag.begin.jsp, .punctuation.definition.tag.end.jsp => .syntax--punctuation.syntax--definition.syntax--tag.syntax--begin.syntax--jsp, .syntax--punctuation.syntax--definition.syntax--tag.syntax--end.syntax--jsp
• .punctuation.section => .syntax--punctuation.syntax--section
• .punctuation.section.embedded.jsp => .syntax--punctuation.syntax--section.syntax--embedded.syntax--jsp
• .punctuation.section.embedded => .syntax--punctuation.syntax--section.syntax--embedded
• .punctuation.separator => .syntax--punctuation.syntax--separator
• .support.class => .syntax--support.syntax--class
• .support.function => .syntax--support.syntax--function
• .support.function.any-method => .syntax--support.syntax--function.syntax--any-method
• .entity.name.function => .syntax--entity.syntax--name.syntax--function
• .entity.name.function.mustache => .syntax--entity.syntax--name.syntax--function.syntax--mustache
• .entity.name.function.decorator => .syntax--entity.syntax--name.syntax--function.syntax--decorator
• .entity.name.class, .entity.name.type.class => .syntax--entity.syntax--name.syntax--class, .syntax--entity.syntax--name.syntax--type.syntax--class
• .entity.name.section => .syntax--entity.syntax--name.syntax--section
• .entity.name.tag => .syntax--entity.syntax--name.syntax--tag
• .entity.other.attribute-name => .syntax--entity.syntax--other.syntax--attribute-name
• .entity.other.attribute-name.html => .syntax--entity.syntax--other.syntax--attribute-name.syntax--html
• .entity.name.type => .syntax--entity.syntax--name.syntax--type
• .entity.other.inherited-class => .syntax--entity.syntax--other.syntax--inherited-class
• .meta.class => .syntax--meta.syntax--class
• .meta.link => .syntax--meta.syntax--link
• .meta.require => .syntax--meta.syntax--require
• .meta.selector => .syntax--meta.syntax--selector
• .meta.separator => .syntax--meta.syntax--separator
• .meta.delimiter.period => .syntax--meta.syntax--delimiter.syntax--period
• .none => .syntax--none
• .markup.bold => .syntax--markup.syntax--bold
• .markup.changed => .syntax--markup.syntax--changed
• .markup.deleted => .syntax--markup.syntax--deleted
• .markup.italic => .syntax--markup.syntax--italic
• .markup.heading .punctuation.definition.heading => .syntax--markup.syntax--heading .syntax--punctuation.syntax--definition.syntax--heading
• .markup.inserted => .syntax--markup.syntax--inserted
• .markup.list => .syntax--markup.syntax--list
• .markup.quote => .syntax--markup.syntax--quote
• .markup.raw.inline => .syntax--markup.syntax--raw.syntax--inline
• .source.gfm .markup => .syntax--source.syntax--gfm .syntax--markup
• .source.gfm .markup.heading => .syntax--source.syntax--gfm .syntax--markup.syntax--heading
• atom-text-editor[mini] .scroll-view, :host([mini]) .scroll-view => atom-text-editor[mini] .scroll-view,atom-text-editor .scroll-view
• .git-config.value-pair.section-item .support.constant => .syntax--git-config.syntax--value-pair.section-item .syntax--support.syntax--constant
• .git-config.value-pair.section-item .punctuation.separator.key-value => .syntax--git-config.syntax--value-pair.section-item .syntax--punctuation.syntax--separator.syntax--key-value
• .git-config.entity.name.section.section.git-config => .syntax--git-config.syntax--entity.syntax--name.syntax--section.syntax--section.syntax--git-config
• .git-config.entity.name.section.subsection.git-config => .syntax--git-config.syntax--entity.syntax--name.syntax--section.syntax--subsection.syntax--git-config
• .git-config.punctuation.section.git-config => .syntax--git-config.syntax--punctuation.syntax--section.syntax--git-config

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Primarily the starting and ending tags <%, <%=, <%@, %>

I would love to use your theme, but it's not yet available publically. It would be cool if you could post it to Atom's theme packages repo.

If it's still WIP, it would be great if you could add a guide to the README on how to install a development version.