attilaszia / nonogram Goto Github PK

When I compile the code with make, everything works like a breeze.

When I run the code with ./solver table.cc my system crashes. I expect that the input is not checked. It would be helpful if it would be checked.

Related to #1 : it would be helpful if an example input file would be added, so that a user can deduce how the program works without documentation

According to Batenburg and Kosters (2009), the algorithm allows for more than two colors (black and white). I want to modify the implementation to allow for multicolored nonograms.

But looking at the code, it seems like this is NOT easy to implement. Correct me if I'm wrong, but the entirety of the implementation assumes only two possible colors, black and white, and thus adding a new color would require a complete refactoring of the entire code base first.

How long do you think it would take to refactor the code to allow for more than two colors? (Ignoring the extra code to load a new file format and the png generation. Those are easy.)

Thanks!

Thanks for adding the examples!

Too bad, it gives a segfault:

In the examples folder:

richel@lubuntu:~/GitHubs/nonogram/examples$ ../solver sheriff_puzzle.txt 
Pic-a-Pix solver 0.1
Initializing solver with: sheriff_puzzle.txt
Initializing a table with sheriff_puzzle.txt
Segmentation fault (core dumped)

In the root folder:

richel@lubuntu:~/GitHubs/nonogram$ ./solver examples/sheriff_puzzle.txt 
Pic-a-Pix solver 0.1
Initializing solver with: examples/sheriff_puzzle.txt
Initializing a table with examples/sheriff_puzzle.txt
Segmentation fault (core dumped)

I volunteer to fix it.

To do so, I will add Travis CI to my fork (I have some experience with it) to test if the examples do work. Feel free to remove the Travis status badge, but all you'll need to do to join in on the Good Practices, is register at https://travis-ci.org (it's free and two clicks if you use your GitHub account). Sure, I volunteer to maintain it.

Additionally, I will add a qmake project file called nonogram.pro. Sure, I volunteer to maintain it.

I hope you agree on the extra goodies I'll give you for free. If not, let me know.