Coder Social home page Coder Social logo

ardis's People

Contributors

mstackhouse avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

ardis's Issues

Make layer appending more verbose

Underlying issue is that if you run add_layer for the same layer twice, you get 2 layers.

Just want to make this informative and clear for users that might not understand completely.

Total rows can't be added after the fact

This works for making totals columns

demog_ard <- adsl %>%
  tardis_table(treat_var = TRT01A, where = SAFFL == "Y") %>%
  add_total_group(group_name = "Total")


# Now let's add some variables we want. First we are going to start with AGE
demog_ard %>%
  add_layer(
    group_count(target_var = AGEGR1, by = "Age (years)")
  )

# To see how this looks we are going to use the build function to build the ARD
demog_ard %>%
  build() 

But this doesn't

demog_ard <- adsl %>%
  tardis_table(treat_var = TRT01A, where = SAFFL == "Y") 


# Now let's add some variables we want. First we are going to start with AGE
demog_ard %>%
  add_layer(
    group_count(target_var = AGEGR1, by = "Age (years)")
  )

# To see how this looks we are going to use the build function to build the ARD
demog_ard %>%
  add_total_group(group_name = "Total") %>%
  build() 

I will note that if you make desc layers it works fine either way

Count layer transparency of denominators used

Make it more transparent that a Big N is being used as a separate denom. Currently, the logic is:

  • Big N's are only used for distinct counts
  • If population data are set, then the Big N's are used
  • If not, distinct denoms are calculated from the target data

Big N Caching

The overarching idea is to be able to make Big N calculations reusable between separate ARDs, so you calculate once and use many times.

Core requirements of the feature:

  • Class the object so appropriate methods can be developed
  • Add capability to import/export the Big N objects
  • Likely need traceability to ensure Big N data isn't obsolete when ard is generated
  • Dependency metadata is stored in Big N object

tadris breaks when piped indirectly

This doesn't work

adsl <- haven::read_xpt(url("https://github.com/phuse-org/TestDataFactory/raw/main/Updated/TDF_ADaM/adsl.xpt"))

# Lets set up our ard. First we are going to define the data source and
# important variables
demog_ard <- adsl %>% 
  tardis_table(treat_var = TRT01A, where = SAFFL == "Y")


# Now let's add some variables we want. First we are going to start with AGE 
demog_ard %>% 
  add_layer(
    group_desc(target_var = AGE, by = "Age (years)") 
  ) %>% 
  build()

But this does

adsl %>% 
  tardis_table(treat_var = TRT01A, where = SAFFL == "Y") %>% 
  add_layer(
    group_desc(target_var = AGE, by = "Age (years)") 
  ) %>% 
  build()

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.