Coder Social home page Coder Social logo

Comments (2)

Noviny avatar Noviny commented on May 28, 2024

Hey Sam! Thanks for raising this issue! It's a good idea, with some design constraints/history worth knowing about before diving in to it.

We actually used to do this (on the extract-react-types side anyway, pretty-prop-types (the rendering engine) always took the first component which is not ideal).

Basically it found everything in your file that was a React.Component.

We switched this when we switched to also analysing functional components, which switched us to analysing export instead of just found components. By only looking at default, we can make an assumption that the export is a component (functional or otherwise), and analyse them like that. In fact, our logic to detect a functional component is just

if (
path.isFunctionExpression() ||
path.isArrowFunctionExpression() ||
path.isFunctionDeclaration()
) {
let component = convertReactComponentFunction(path, context);
components.push({ name, path, component });
return;
}

:badpokerface:

Analysing multiple exports and being confident they are all components probably means implementing real logic here that determines whether a function is a function component or not.

(Though we want to do that anyway, as extract-react-types does enough now we're thinking about pointing it at function and object signatures, as it theoretically does these anyway)

Uh, hope that helps answer your question!

The easy answer is yes, qualified by the above.

from extract-react-types.

Noviny avatar Noviny commented on May 28, 2024

ps. If you want to just use multiple exports now, you can via this exported function that we have failed to document:

module.exports.findExportedComponents = (
programPath /*: any */,
typeSystem /*: 'flow' | 'typescript' */,
filename /*:? string */,
resolveOptions /*:? Object */
) => {
return findExportedComponents(
programPath,
'all',
getContext(typeSystem, filename, resolveOptions)
);
};

from extract-react-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.