Decouple from atlaskit website build about extract-react-types

[marionebl]

Alternatively we could in-source the loader, what's your take @danieldelcore ?

[danieldelcore]

Hey @marionebl 👋

Remove the direct access and expose config keys instead

Can you elaborate on this a bit? I'm not sure I understand 🤔

I agree that this condition could probably be moved out of this repo and toggled on/off however the user requires.

!['staging', 'production'].includes(process.env.WEBSITE_ENV) && !process.env.FORCE_EXTRACT_REACT_TYPES

Is there a nice way to do this in webpack? I guess by providing different configs for different environments 🤔

[marionebl]

Is there a nice way to do this in webpack? I guess by providing different configs for different environments 🤔

Our own usage is mostly inline-loader requires, e.g.

require('!!extract-react-types!./Button.tsx');

Unfortunately there is no straightforward way to have user-configurable defaults for those - the conventional way to pass options in is query parameter 😬

require('!!extract-react-types?a=b!./Button.tsx');

In our case we could use the resolveLoader config to alias extract-react-types-loader to the noop branch, e.g.

    resolveLoader: {
      alias: opts.extractReactTypes ? undefined : {
        'extract-react-types-loader': require.resolve('./noop-extract-react-types-loader'),
      },
    },

The npm module could make this slightly nicer by providing a noop entry point:

    resolveLoader: {
      alias: opts.extractReactTypes ? undefined : {
        'extract-react-types-loader': require.resolve('extract-react-types-loader/noop'),
      },
    },