The saitekx52pro from atcurtis

saitekx52pro's People

Contributors

Stargazers

Watchers

saitekx52pro's Issues

Garbled MFD and hung joystick

Hi
Thanks for a very nice library, works fine.

I have discovered an inconvenient issue which I have solved (sort of), and I just wanted to inform you of this.
Sometimes I get a garbled MFD on my X52 Pro joystick when writing text using:
setText(int line, CharSequence text)
It also sometimes completely hung the joystick requiring a disconnect/connect of the USB plug.

I solved this by adding sleep for 1 ms. Perhaps not the most elegant solution, but it decreased the number of garbled writes by ca 90% and the hanging by 100%:

   public void setText(int line, CharSequence text) {
    if (!feat_mfd)
      throw new UnsupportedOperationException("setText not supported");
    if (line < 1 || line > 3)
      throw new IndexOutOfBoundsException("line number out of bounds");
    int r = controlMsg(clear_idx[line], (short) 0x0000);
    if (r < 0)
      throw new LibUsbException("setText failed to clear", r);
    if (r < 0)
      throw new LibUsbException("failed at clear command: " + LibUsb.strError(r), r);
    for (int index = 0, length = text.length(); length > 0; index+=2, length-=2) {
      short chars;
      if (length == 1) {
        chars = (short) ( (' ' << 8) | text.charAt(index) );
      }
      else {
        chars = (short) ( (text.charAt(index + 1) << 8) | text.charAt(index) );
      }
      r = controlMsg(write_idx[line], chars);
      if (r < 0)
        throw new LibUsbException("setText failed", r);
      // Added short sleep to avoid garbled MFD and hung joystick
      try {
        Thread.sleep(1);
      } catch(InterruptedException ex) {
        Thread.currentThread().interrupt();
      }
    }
  }

Recommend Projects