ashwinimadapura / calculator

Hi there 👋, I am Ashwini Madapura

---

A Junior Software Engineer specializing in VBA, SQL, Java Script, React, Java, HTML, SCSS, MS Excel. I have hands-on experience in tools such as Postman, Figma, Confluence, Trello, Jira, Putty, SVN, Oracle Service, Tidal Automation, FTP and Winscp. Professional experience with the technologies listed in the toolbox below.

I have almost 2 years of work experience at Citi as Junior Software developer and 3 years at Accenture as an Application Development Analyst.

I was part of _nology 12 weeks training where I covered HTML, CSS, SCSS, JS, REACT, JAVA and Cloud which is a full-stack development. I got to work with client-based project using React and followed Agile methodology for development process.

I completed my stream Training as software Tester which is 1 month course, completing Manual Testing and Automation Testing which includes Selenium, Cucumber and UFT.

---

🧰 Toolbox

---

🔗 Connect with me

📈 My Stats

calculator's Issues

Calculator feedback

Site

• Great stuff Ashwini, you’ve managed to create a working calculator responsive across multiple screen size which is great 😊
• Don’t be afraid to get rid of more of the default styles off those buttons e.g. the border - as users when we see them applied it tends to make our styles look a bit outdated.

---

Code

• Well done for getting some quite complex logic here, Ashwini - solving this challenge with arrays is tricky!

A couple of points to improve to next time:

• Try to choose descriptive names for your variables and function - it makes it much easier for other devs and yourself if you look back at this project in a few months to understand what’s going on. Your variable of flag1 is a bit weird to me - what does that mean? It looks like a boolean value so I would expect it to be prefixed with something like is
• You should be using arrow functions - named functions, on line 19, 52, 59 are hoisted which can lead to some weird behaviour, which is why suggest we avoid them.
• Your clickNumber function has too many levels of nested if else statements - this makes it really hard to figure out what going on. Suggest seeing if you can refactor and break down further into smaller functions, and add some comments so its easier to understand.
• Have another look at the difference between querySelectorAll and querySelector - you could have used the latter for your equals button because we know there is only one of them!