ashirt-ops / ashirt-deployments Goto Github PK

When running terraform, the following warning is displayed. While this isn't an immediate issue, it should be fixed to avoid any problems in the future.

╷
│ Warning: Argument is deprecated
│ 
│   with aws_s3_bucket_object.webenv,
│   on s3.tf line 46, in resource "aws_s3_bucket_object" "webenv":
│   46:   bucket = aws_s3_bucket.env.id
│ 
│ Use the aws_s3_object resource instead
│ 
│ (and one more similar warning elsewhere)

ECS API Task Exception:

Upload to s3 failed : MissingRegion: could not find region configuration" rootError="Unable to upload evidence : Upload to s3 failed : MissingRegion: could not find region configuration" status=500 url=/api/operations/test/evidence

This only happens when attempting to upload evidence from the Ashirt Client and not from the WebUI. The WebUI works fine.

Attempted to Patch

1. Made sure we have default region set for all ECS containers/tasks. That did not seem to do anything.

Checking the current config:

• aws ecs describe-task-definition --task-definition post-api:2 --region us-east-1

"environment": [
                    {
                        "name": "AWS_DEFAULT_REGION",
                        "value": "us-east-1"
                    }
                ],
                "environmentFiles": [
                    {
                        "value": "arn:aws:s3:::post-ashirt-env/app/.env",
                        "type": "s3"
                    },
                    {
                        "value": "arn:aws:s3:::post-ashirt-env/db/.env",
                        "type": "s3"
                    }
                ],

When using the ECS deployment, the configured ACLs block ssh access to the EC2 instance.

Here is a screen shot showing that inbound ssh access to the instance is blocked by the ashirt-main ACL.

The terraform config should be updated so that inbound ssh is allowed to the maintenance EC2 image when it is deployed.

Having a brief description to go along with each of the default tags would help people choose the correct ones.

For example, having MITRE's ATT&CK framework tags with a sentence describing the core essence or an example would help familiarize users with them.

The picker UI would need to change to add a description display box.