arthmoor / smaugfuss Goto Github PK

http://c-faq.com/stdio/getcharc.html

Apparently it's somewhat common for people to try to run SmaugFUSS on ARM devices like Raspberry Pis, which have unsigned chars, not signed chars, and then get confused when it sort of looks like it's working but then errors in weird ways.

If char is unsigned, then code like

overruns its buffer, because fgetc returns an int, not a char, which then gets converted from signed -1 to unsigned 255, and EOF is -1, which means the comparison always fails.

See also https://www.raspberrypi.org/forums/viewtopic.php?t=217769

Based purely on visual inspection of the code, various places in weather.c appear to read and write past the end of the weatherMap storage.

I think

   if( x < 0 || x >= WEATHER_SIZE_X )
   {
      ch_printf( ch, "X value must be between 0 and %d.\r\n", WEATHER_SIZE_X-1 );
      return;
   }

   if( y < 0 || y >= WEATHER_SIZE_Y )
   {
      ch_printf( ch, "Y value must be between 0 and %d.\r\n", WEATHER_SIZE_Y-1 );
      return;
   }

and

   x = number_range( 0, WEATHER_SIZE_X-1 );
   y = number_range( 0, WEATHER_SIZE_Y-1 );

Several places in the Makefile invoke -fsanitize=address but I don't think Cygwin has libasan so this causes build errors.

In #2 I mentioned

(Also, what does it mean for a string to be twice the max length? Isn't the max length then not the max?)

Now you could say "that file should never be so large", and maybe, but some of the people who are trying to run SmaugFUSS don't know what that means, and some may even unwittingly modify MAX_STRING_LENGTH to be smaller.