arodus / azure-keyvault Goto Github PK

When using KeyVaultSecretAttribute and KeyVaultSettingsAttribute, you get an NotSupportedException when trying to get the value. This is due to a call for getting MemberType with null value.

The problematic code is in KeyVaultSettingsAttribute here:
` [NotNull]
public override object GetValue(MemberInfo member, object instance)
{
var memberType = member.GetMemberType();
ControlFlow.Assert(memberType == typeof(KeyVaultSettings), "memberType == typeof(KeyVaultConfiguration)");
AssertIsValid();

        return new KeyVaultSettings
               {
                   ClientId = string.IsNullOrWhiteSpace(ClientId) ? GetParameter(ClientIdParameterName, instance) : ClientId,
                   BaseUrl = string.IsNullOrWhiteSpace(BaseUrl) ? GetParameter(BaseUrlParameterName, instance) : BaseUrl,
                   Secret = GetParameter(ClientSecretParameterName, instance)
               };
    }

    public KeyVaultSettings GetValue(object instance)
    {
        return (KeyVaultSettings) GetValue(member: null, instance);
    }`

Attributes in the library still use the old way of using ParameterService, while it was still public.
Now that it is internal, they fail in runtime if you use it with newer version of Nuke.Common.

Suggested fix:
Replace code like new ParameterService().GetParameter<string>(secretName) with EnvironmentInfo..GetParameter<string>(secretName).