arkworks-rs / r1cs-tutorial Goto Github PK

Summary

Can you update dependencies to latest version of arkworks?

Problem Definition

There are many errors when updated version of dependencies to 0.4.2.

Summary of Bug

Pedersen Hash Improper Configuration

Version

This tutorial's configuration of pedersen hash window
(https://github.com/arkworks-rs/r1cs-tutorial/blob/main/merkle_tree_example/src/common.rs#L18):

pub type TwoToOneHash = PedersenCRHCompressor<EdwardsProjective, TECompressor, TwoToOneWindow>;
#[derive(Clone, PartialEq, Eq, Hash)]
pub struct TwoToOneWindow;

// `WINDOW_SIZE * NUM_WINDOWS` = 2 * 256 bits = enough for hashing two outputs.
impl pedersen::Window for TwoToOneWindow {
    const WINDOW_SIZE: usize = 128;
    const NUM_WINDOWS: usize = 4;
}

pub type LeafHash = PedersenCRHCompressor<EdwardsProjective, TECompressor, LeafWindow>;

#[derive(Clone, PartialEq, Eq, Hash)]
pub struct LeafWindow;

// `WINDOW_SIZE * NUM_WINDOWS` = 2 * 256 bits = enough for hashing two outputs.
impl pedersen::Window for LeafWindow {
    const WINDOW_SIZE: usize = 144;
    const NUM_WINDOWS: usize = 4;
}

Which configure the window_size to N, and the num_windows to 4. This is not consistent with the arkworks test:
(https://github.com/arkworks-rs/crypto-primitives/blob/main/src/merkle_tree/mod.rs#L463).

From my understanding, this will introduce a potential security vulnerability.

Happy to create a PR if this is confirmed by arkworks devs.

Steps to Reproduce

The whole project cannot be compiled, due to ark-crypto-primitives is always going to pull the latest commit from github.
But it compiled while I used specified commit

Platform:
rust: 1.52.1
os: ubuntu 20.04

Perhaps that Cargo.lock file can avoid this situation.

In Merkle tree example, the error shows the 'leaf_bytes' didn't implement 'ToBytesGadget'. But the 'leaf_bytes' is the default value. So how can I deal with it?

Summary of Bug

The README for the merkle tree example in the R1CS tutorial incorrectly states that it will show how to invoke a SNARK when actually the example is only about generating the constraints and verifying satisfiability directly using the witness input itself. This is confusing for beginners trying to learn arkworks.

Version

commit 5d3a902

Steps to Reproduce

Compare the README to the example code.