archlinux / contrib Goto Github PK

View Code? Open in Web Editor NEW

58.0 58.0 17.0 169 KB

Arch contrib scripts

License: GNU General Public License v2.0

Shell 62.84% Python 35.13% Makefile 2.03%

contrib's People

Contributors

Stargazers

Watchers

Forkers

grazzolini msgpo lahwaacz tubbz-alt kgizdov denisse-dev orhun cmm1107 cyberx9901 starquake samkenxstream viktorf paulfrische uggedal antonio-rojas seanpm2001 ana7r

contrib's Issues

Shellcheck shows some warnings for package/diffpypi

Here´s the link for shellcheck´s output

Checkservices. Unable to find/parse PID for systemd-udevd and shadowsocks service

I put a hook to full system upgrade to launch checkservices command from https://archlinux.org/packages/?name=archlinux-contrib.
Here is an output

:: Synchronizing package databases...
 core is up to date
 extra is up to date
 community is up to date
:: Starting full system upgrade...
 there is nothing to do
:: Run pacdiff
:: Reload systemd
:: Services with broken maps files
Error:: Unable to find pid file for shadowsocks-rust@config_rust.service.
Error:: Unable to parse pid file for systemd-udevd.service.
Found: 0
:: Services missing on the system bus
:: List failed units

Actually the question is how to fix that Errors. Either udevd service or shadowsocks service working without errors.

If it matters I'm using linux-hardened kernel.

> sudo systemctl show systemd-udevd.service | grep PID
[sudo] password for lex:
GuessMainPID=yes
MainPID=278
ControlPID=0
ExecMainPID=278

Produced output is unreadable

Running checkservices produces "invisible" output on terminals with light/non-black background. The text is there but it has the same color as terminal background. Here is a screenshot:

All terminals I tried (xfce4-terminal, xterm, tilix) result in invisible text.

OS: Arch Linux (up-to-date)
Version: 20221211-2

rebuild-todo: show list of rebuild packages when done

When done, show the exact list of rebuild packages again for clarity.

checkservices: Unable to parse pid file for systemd-udevd.service

Hello. When running checkservices,I'm getting the following error:

$ sudo checkservices
:: Run pacdiff
:: Reload systemd
:: Services with broken maps files
Error:: Unable to parse pid file for systemd-udevd.service.
Found: 0
:: Services missing on the system bus
Found: 0
:: List failed units

I am certain that I did not get that error before, but I'm unaware of any recent changes that might have prompted this.

I poked around a bit:

$ sudo systemctl show systemd-udevd.service | grep PID
GuessMainPID=yes
MainPID=300
ControlPID=0
ExecMainPID=300

That is as far as I got unfortunately. This might very well be my fault - somehow.

Is this something I can fix or a bug?

Thank you for your time!

Add infrastructure files to contrib

https://gitlab.archlinux.org/archlinux/infrastructure/-/tree/master/roles/archbuild/files

rebuild-todo: commiting straight to [core] is disallowed

[core] packages must go through [testing], hence the default target should be [testing] without a possibility to commit straight to [core]

Parse error in pkgsearch script.

When trying to use the pkgsearch script I keep getting the following error:

parse error: Invalid numeric literal at line 1, column 7
parse error: Invalid numeric literal at line 1, column 7

checkservices: broken parsing of systemctl output

It seems that my fix in #20 was not the best - the systemctl command does not print only leading spaces, but the first character can be an arbitrary "mark":

$ systemctl --no-legend --full --type service --state running
  dbus.service                   loaded    active running D-Bus System Message Bus
  nginx.service                  loaded    active running A high performance web server and a reverse proxy server
● org.cups.cupsd.service         not-found active running org.cups.cupsd.service
  polkit.service                 loaded    active running Authorization Manager
...

So passing it to awk '{print $1}' will give ● instead of org.cups.cupsd.service which is not a valid unit name.

checkservices: cgroup v2 base path

checkservices currently checks /sys/fs/cgroup/systemd as the cgroup base path:

contrib/admin/checkservices

Line 31 in 48e9539

SYSTEMD_CGROUP_BASE_PATH='/sys/fs/cgroup/systemd'

However, if the cgroup v2 hierarchy is used, /sys/fs/cgroup/systemd does not exist and systemd uses /sys/fs/cgroup directly.

have offload-build copy packages to package folder (PKGDEST)

@eli-schwartz can we get offload-build{-new} to copy files to PKGDEST on the initiating machine?

rebuild-todo: confirm option is a bit vague

I just left the tool with "Confirm..." maybe it should just show "Press enter to confirm"

checkservices: Error:: Unable to read maps file of dropbear.service for pid XXXXXXX.

For dropbear the checkservices script seems unable to pickup the correct pid for the service.

# checkservices
:: Run pacdiff
:: Reload systemd
:: Services with broken maps files
Error:: Unable to read maps file of dropbear.service for pid 1259966.
...
# systemctl status dropbear
* dropbear.service - Dropbear SSH Server
     Loaded: loaded (/usr/lib/systemd/system/dropbear.service; enabled; vendor preset: disabled)
     Active: active (running) since Wed 2022-02-23 09:39:48 CET; 52min ago
   Main PID: 1259409 (dropbear)
...
# checkservices
:: Run pacdiff
:: Reload systemd
:: Services with broken maps files
Error:: Unable to read maps file of dropbear.service for pid 1260860.
Found: 0
# pacman -Q archlinux-contrib
archlinux-contrib 20210710-1

checkservices: Unable to parse pid file for [email protected]

When running checkservices, I am getting the following error:

$ sudo checkservices
:: Run pacdiff
:: Reload systemd
:: Services with broken maps files
Error:: Unable to parse pid file for [email protected].
Found: 0
:: Services missing on the system bus
Found: 0
:: List failed units

Am I doing something wrong? This seems like a common service to have.

parse-submodules: support recursive parsing

Submodules of submodules are not parsed and added to the sources array and are currently initialized by git -c protocol.file.allow=always submodule update --init --recursive

Related todo lock git submodules.

Autoconfirm doesn't work

checkservices -h says:

usage checkservices [options]
description: check for updated files in a service
options:
  -h: this help
  -c: auto confirmation
  -l/-L: call (or not) systemd daemon-(reload|reexec) (default: 1)
  -f/-F: display (or not) failed services before quit (default: 1)
  -p/-P: call (or not) pacdiff before act (default: 1)
  -r/-R: restart (or not) services with updated files (default: 1)
  -s/-S: display (or not) status of restarted service (default: 1)
  -u/-U: act (or not) on services in users slice (default: 0)
  -z/-Z: serialize (or not) action (default: 0)

But when I do:
checkservices -c it says:

/usr/bin/checkservices: illegal option -- c

I see this in the code, but it looks like it disables autoconfirm.

co-maintainers lists duplicates for split packages

The output for me returns f.ex. mediainfo and mediainfo-gui, which belong to the same split package, leading to two mediainfo pkgbases in the output.

Either find_packages should return pkgbases, or a unique filter should be added to the final output.

rebuild-todo: mark packages as auto-completed

Nice to have.