arcaniax-development / gobrush Goto Github PK

https://gyazo.com/fad9ed58db0ebf3de85b19794b0ad5ef

By opening the gobrush menu, the following exception is printed:

Serverversion: 1.16.5 Paper

[12:01:34 ERROR]: Could not pass event InventoryClickEvent to goBrush v3.6.0 java.lang.NullPointerException: null at com.arcaniax.gobrush.listener.InventoryClickListener.mainMenuClickEvent(InventoryClickListener.java:118) ~[?:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor130.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.16.5.jar:git-Paper-626] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.16.5.jar:git-Paper-626] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.16.5.jar:git-Paper-626] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.PlayerConnection.a(PlayerConnection.java:2701) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.PacketPlayInWindowClick.a(SourceFile:32) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.PacketPlayInWindowClick.a(SourceFile:10) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.PlayerConnectionUtils.lambda$ensureMainThread$1(PlayerConnectionUtils.java:35) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.TickTask.run(SourceFile:18) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.MinecraftServer.bb(MinecraftServer.java:1262) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.MinecraftServer.executeNext(MinecraftServer.java:1255) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.MinecraftServer.sleepForTick(MinecraftServer.java:1216) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1130) ~[patched_1.16.5.jar:git-Paper-626] at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:289) ~[patched_1.16.5.jar:git-Paper-626] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282]

What feature do you want to see added?

When the player right clicks, there is an attempt to find the first block they are looking at. The loop for this moves half a block at a time so each block is checked ~twice for if it matches the condition or not.

Over a couple tests, profiling my server as I ran the commands, the getType() call accounted for about 50% of the operation.

I suggest only running checks on a block if the position (loc variable) has actually changed block position.
Doing so removes about half of these calls and gives a sizable performance boost.

Before:

After:

Are there any alternatives?

Leaving as is still functions but is slower.

Anything else?

I looked in to this after the Bakery server disabled goBrush & goPaint due to performance concerns

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency com.intellectualsites.bom:bom-newest to v1.46

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>whitesource/merge-confidence:beta)

Session.initializeValidBrushes(); - This method clears a map then loads all the brushes from scratch again. This is.. Rather laggy if you have a fair amount of brushes.

https://github.com/Arcaniax-Development/goBrush/blob/master/src/main/java/com/arcaniax/gobrush/object/BrushPlayer.java#L63

This is why its called on player join.

• Optimize usage of player and inventory listener; currently the brush inventory may bring some performance regression based on (often) done being superseded by others.
• Having a large brush folder/many files in total may slow down or hang your server, whether you have a solid disk i/o or not.
• Do not assign a brush session in sync if not necessary [5deec14]

Server Implementation

Paper

Server Version

1.17.1

Describe the bug

Just to be clear, I am on 1.18.1, but the server version isn't added for that.

Using goBrush below 0 or above 255 leads to nothing happening when right clicking the flint tool.

To Reproduce

1. Create a flat world or just be above or below original world limits (below 0 or above 255).
2. Attempt to use goBrush on blocks outside that original region.
3. Profit.

Expected behaviour

goBrush does as expected and works within the new world limits to build.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste (if applicable)

No response

goBrush Version

3.8.0-46

Checklist

• I am using the newest build from https://ci.athion.net/job/goBrush-1.13+/ and the issue still persists.

Anything else?

No response

What feature do you want to see added?

To make the Plugin more compatible with other ones, a config option to choose which Material should get used by goBrush would be pretty nice.

Are there any alternatives?

I searched for Config Options in other Plugins but couldn't find anything.

Anything else?

No response

Server Implementation

Purpur (Paper)

Server Version

1.18.1

Describe the bug

Right clicking the ground / a block outputs twice.

To Reproduce

1. Spawn in flint.
2. Look down.
3. Right click.

Expected behaviour

Only one output like goPaint.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste (if applicable)

No response

goBrush Version

goBrush version 3.8.0-47

Checklist

• I am using the newest build from https://ci.athion.net/job/goBrush-1.13+/ and the issue still persists.

Anything else?

Listening for any interact event, thus triggering from offhand too?

Using Purpur dev 1561 (Paper 1.18.1).