arcalot / arcaflow-plugin-template-python Goto Github PK

Please describe what you would like to see in this project

Change the Dockerfile to explicitly specify a poetry version to avoid drift.

Please describe your use case

Being non-explicit about the poetry version can lead to feature or bug drift that may suddenly break the build system even when no changes are made to the underlying plugin code or dependencies.

Additional context

We've recently run into build failures that are traced back to poetry automatically removing packages at build time that are dependencies for our test executions built into the Dockerfile. We still aren't sure if this is a feature or a bug change in poetry, but either way it is a problem triggered by drift.

Please describe what you would like to see in this project

Our plugin dockerfiles should be built from globally standardized plugin base images where we can centrally control versions of the OS and dependency packages/modules.

Please describe your use case

This is important to avoid version drift in the container definitions that can break CI builds and even plugin functionality.

Please describe what you would like to see in this project

Find a way to automate test coverage data and display it automatically in PR's.

Please describe your use case

This will create a smaller final image as well as automate the coverage data for consumption

Additional context

Possible solution. https://coveralls.io/

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

⚠ Dependency Lookup Warnings ⚠

• Renovate failed to look up the following dependencies: Failed to look up github-tags package actions/checkout, Failed to look up github-tags package actions/upload-artifact.

Files affected: .github/workflows/build.yaml

This repository currently has no open or pending branches.

Detected dependencies

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: None
Error type: Invalid gitAuthor
Message: gitAuthor is not parsed as valid RFC5322 format: Platform Engineering Bot

Describe the bug

carpenter action passes but output says:

2022-10-12T05:43:41Z	info		Missing pyproject.toml
2022-10-12T05:43:42Z	info		Failed requirements check, not building: arcaflow-plugin-template-python latest

I'm going to open an issue on carpenter for failing if not executed but if pyproject.toml is requried, we need to add it here too.

    Is the only difference between `carpenter_build.yaml` and `carpenter_push.yaml` the addition of `--push` on lines 27 and 45?

If so, isn't there a way to have the carpenter_push.yaml just use carpenter_build.yaml telling it to also use --push? That would DRY it out.

Originally posted by @portante in #14 (comment)