Coder Social home page Coder Social logo

koa-branch-router's People

Contributors

aravindanve avatar dependabot[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

dreambiglabs

koa-branch-router's Issues

Named params cause issue with nested routers

It seems like this quirk is having a pretty annoying side effect

  • Named parameters assume trailing slash :userId => :userId/

If you are trying to nest routers it causes the following issue

const router = new Router()

router.use("/test/:id",
  new Router()
    .get("/", async ctx => {
      ctx.body = "Slash OK"
    })
    .get("/nested", async ctx => {
      ctx.body = "OK"
    }))

To access the nested router you need a double slash

http://localhost:3001/test/1//nested

I've manage to do a hack around it by using, but it would be amazing if this worked as expected

router.use("/test",
  new Router({ prefix: "/:id"})
    .get("/", async ctx => {
      ctx.body = "Slash OK"
    })
    .get("/nested", async ctx => {
      ctx.body = "OK"
    }))

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.