appteam-nith / hillffair

This is the official Repository for Android Application for Hillffair, NIT Hamirpur

Hillffair

This is the official Android Application of the Cultural Fest of NIT Hamirpur Hillffair made by YOU 😄.

Screencast link: https://youtu.be/JNsIbjpm2l8

The App is currently on Playstore under link: https://play.google.com/store/apps/details?id=appteam.nith.hillffair

How to setup this project in Android Studio :-

1. Firstly, fork this repo from the main repository appteam-nith/Hillffair by clicking on the Fork button.

2. Now clone the forked repo in your PC. For this first copy the url of your forked repo (use terminal or git bash):

   git clone https://github.com/[username]/Hillffair.git

   [username] is replaced by your github username.

3. Finally, open this project in Android Studio.

4. Happy Hacking 😉

Contact us or Report a bug at [email protected]

How to contribute to this project :-

1. Go through the entire project after building it, look for bugs and report them if you find any.

2. View the issues put up in the repo and try to fix them. You may send us a pull request after that.

3. IMPORTANT :- Before sending a Pull Request make sure that your forked repository is in sync with the base repository Click Here .

Note: Also while sending Pull Request make sure all naming conventions are followed, files must be present in corresponding package.

Libraries used

• Glide
• Retrofit
• OneSignal
• Okhttp
• Gson
• Load-Toast

License

This project is currently licensed under the GNU General Public License v3.
For more details see LICENSE.md.

hillffair's Issues

Username is NOT username

username input box in login screen takes email as input. Shouldn't it be email instead @RamolaWeb

Login screen layout doesn't fits in small screen sizes.

The Signup part on the login screen is not visible on screens with sizes 4.5 inches & less.
Either it should be added inside a scroll view or it can be replaced with a button, below the login button.

Cannot Finish the quiz

App icon needed

App crashes during signup

When any of
isName , isemail ,ispassword , isphone

Get true under "if " condition 'SignupActivity.java'
The app crashes during the filling of form.

Cannot Finish the quiz

If the time runs out during the quiz, one cannot finish the quiz as nothing happens if we click on finish the quiz

OOP not being followed

OOP principles not being followed in practice (There is no base activity)
Please refer this :
https://docs.oracle.com/javase/tutorial/java/concepts/index.html
https://scotch.io/bar-talk/s-o-l-i-d-the-first-five-principles-of-object-oriented-design

Note : This is only intended for your learning Make sure the NImbus App will adhere to this

Layout Issues with the SignUp Activity

App redirecting to login after register

@sukhbir-singh @RamolaWeb Make sure to think about it. Cannot repeat same mistakes

Transitions needed between activities

Suitable transition is required to be added to app between activities

App Crashing When Trying to send code in forgot password

I tried to send myself a code on my email but the app crashed. Make sure its solved asap

Newsfeed showing wrong name always show "Sahil Ramola"

When i submit newsfeed it is showing name as sahil ramola not mine

Register and Login scenario is too hectic and boring

@RamolaWeb @sukhbir-singh Can't we have more interactive ways of login and easy logins and registering

App needs MVP

Hello guys!! For better code structuring Make sure you follow MVP (Model View Presenter).

Learn Here
https://github.com/konmik/konmik.github.io/wiki/Introduction-to-Model-View-Presenter-on-Android
https://code.tutsplus.com/tutorials/an-introduction-to-model-view-presenter-on-android--cms-26162

Note : Intended only for future implementation of NIMBUS app.

appbar colors in various activites should match with selected theme

Layout Issues with the SignUp Activity

landscape view of login activity need to be consistent as portrait view

change landscape view component to be similiar to portrait view of login activity, change edit text views, reposition bottom most line "Dont have account" to bottom of screen

Toolbar labels are of Black colour

When applying batman theme, it is hardly visible labels "Clubs", CoreTeam etc..

This should changed according to theme

Wrong Toast

A wrong toast is being shown stating "Error:-wrong user id" after the user data is loaded to the user profile tab.

Settings page's theme need to be updated as soon as new theme is selected

AtPresent updated theme will only be visible when we press back button on changing theme from settings page, But here we want instant update of theme of settings as well when a user selects a new theme.

Java naming Conventions not being followed

Make sure all naming a conventions are followed in the code.
@RamolaWeb @sukhbir-singh Make sure this refractoring is done ASAP
A little help for beginners :
http://www.oracle.com/technetwork/java/codeconventions-135099.html

Colour Pallete of app needs a discussion

@RamolaWeb make sure we have a better colour scheme for app.