VisualStudioReporter incorrect comparison order of approved and received? about approvaltests.net

[SimonCropp]

this can now be controlled using an environment variable https://github.com/VerifyTests/DiffEngine/blob/main/docs/diff-tool.md#leftright-diff-behavior

[SimonCropp]

@MihailsKuzmins

changing DiffRunner.Launch(diffTool, received, approved); wont work DiffRunner.Launch has logic in it that assumes the received and approved are passed in in the correct order.

If you want to change this, it should be a PR in https://github.com/VerifyTests/DiffEngine that inverts the display order via an environment setting

[MihailsKuzmins]

@SimonCropp, thank you that you corrected my mistake of the design.
So as I understood VisualStudio.cs must be changed, to be more specific this line (temp, target) => $"/diff \"{temp}\" \"{target}\"",. So the first file is "received" and the second is "approved".

ApprovalTests.Net/src/ApprovalTests/Reporters/DiffToolReporter.cs

Lines 15 to 18 in 443565a

	public void Report(string approved, string received)
	{
	DiffRunner.Launch(diffTool, received, approved);
	}

So I ran this test. And indeed the "received.json" was on the left-hand side.
So in VisualStudio.cs I only made this change and after that the result was as I would expect ("received.json" was on the right-hand side)

If you agree that this change is all right I will prepare a PR in the DiffEngine.

[SimonCropp]

discussing on diffengine repo so will close this

[MihailsKuzmins]

@SimonCropp,
thank you so much, your solution is more general and will cover similar cases in other reporters.
Tested the new version and it works as expected. Waiting for the new NuGet release

Environment.SetEnvironmentVariable("DiffEngine_TargetOnLeft", "true");

[SimonCropp]

the nuget is deployed. but note that you should not add SetEnvironmentVariable("DiffEngine_TargetOnLeft to your code