applio / lightlora_micropython Goto Github PK

Sections like this (from sx127x.py) seem ripe for employing const() to lower memory consumption:

# registers
REG_FIFO = 0x00
REG_OP_MODE = 0x01
REG_FRF_MSB = 0x06
REG_FRF_MID = 0x07

The order of the arguments in the definition suggest destination then source:

def sendPacket(self, dstAddress, localAddress, outGoing):

When accessing packets received, the values appearing in packet.dstAddress and packet.srcAddress appear reversed (where packet is an instance of LoraPacket)?

Currently, params are hard-coded in the init:

        params = {
            'tx_power_level': 5,
            'signal_bandwidth': 125E3,
            'spreading_factor': 7,
            'coding_rate': 5,
            'enable_CRC': True,
        }

Exposing them in the init would permit other spreading factors, etc. to be easily experimented with or set.

Per https://docs.micropython.org/en/latest/pyboard/library/utime.html:

Some boards may accept seconds as a floating-point number to sleep for a fractional number of seconds. Note that other boards may not accept a floating-point argument, for compatibility with them use sleep_ms() and sleep_us() functions.

Try applying black (ref: https://black.readthedocs.io/en/stable/) to see how it does here.

Methods such as LoraUtil.sendPacket look more Java or C++ like. A more pythonic name might be LoraUtil.send_packet.