apparentsoft / reactivecoredata Goto Github PK

Non-prefixed methods (e.g.: + (RACSignal *)findAll) will conflict with other libraries (e.g. MagicalRecord)

So, all methods should be renamed to prefixed version.

old

+ (RACSignal *)findAll;

new

+ (RACSignal *)rac_findAll;

FYI:
"Namespacing - NSHipster" http://nshipster.com/namespacing/

Lots of Core Data applications will use NSFetchedResultsController to manage their UITableViews and UICollectionViews.

It provides a good level of control through its delegate protocol, and lets the user update tables relatively easily with some boilerplate code supplied by the Apple documentation.

Where does RCD come in on this matter?

Hi!

First of all, I wanna say thanks for creating and sharing this cool stuff, I'm looking forward to using it in my projects. And I feel like there are a couple things that could be done to make it even better :)

Here are the points I wanna ask you about:

• Wouldn't it be better to use parent-child context hierarchy for background operations? I believe that this newer way is generally more preferable and convenient than doing merge with didSave notifications, because it doesn't require any additional setup. rcd_merged signal can be replaced with a signal for NSManagedObjectContextObjectsDidChangeNotification to serve the similar purpose.
• This point kind of follows up the previous one. It feels like the methods + (NSManagedObjectContext *)context and + (NSManagedObjectContext *)currentContext in the NSManagedObjectContext (ReactiveCoreData) category are a bit confusing... Perhaps we could just eliminate the former one?
• The methods - (RACSignal *)findAll: and - (RACSignal *)findOne: in RACSignal (ReactiveCoreData) category ignore the receiver completely and just return new signals... I guess they should be class methods instead?
• Would it make sense to move methods + (instancetype)insert and + (instancetype)insert: from NSManagedObject (ReactiveCoreData) to some other place or maybe remove them completely? They seem like they have nothing to do with ReactiveCocoa stuff :)

Let me know what do you think about this. If you are okay with these points, I'm willing to contribute :)

It would be useful to be able to do the following:

[[[[MyEntity findAll] where:@"name" equals:@"joe"] where:@"cars.@count" equals:@(1)] fetch]

and have this generate a compound predicate for the fetch request. I know you can accomplish the same thing without this today, but I find this a bit more readable. I'll have a pull request shortly.