appacademy / practice-for-week-04-es5-classes

Practice: ES5 Classes

In this practice, you will use ES6 class syntax to define classes and monkey-patch an existing class.

Set up

Clone the starter from the Download link at the bottom of this page.

Run npm install to install any dependencies.

Phase 1: Refactor classes into ES5 class syntax

Take a look at the classes/dog.js file. The test specs for the Dog class in the test/dog-spec.js file are already passing. Refactor the Dog class to use ES5 class syntax instead. Test your code to make sure it still works after the refactor by running the following command:

npm test test/dog-spec.js

Take a look at the classes/person.js file. The test specs for the Person class in the test/person-spec.js file are already passing. Refactor the Person class to use ES5 class syntax instead. Test your code to make sure it still works after the refactor by running the following command:

npm test test/person-spec.js

Phase 2: Monkey-patch the Array class

Finally, take a look at the classes/array.js file. Monkey-patch the Array class so that all the test specs in the test/array-spec.js file pass. Run the test specs with the following command:

npm test test/array-spec.js

Hint:

The method you are adding to the Array class tests if two arrays are deeply equal.

practice-for-week-04-es5-classes's Issues

array-spec.js

The test specs need an additonal test unit to check for arrays of different lengths
currently this implementation passes the test units but it shouldn't

Array.prototype.isEqual = function (arr) {
   

    for (let i = 0; i < this.length; i++) {
        if (this[i] !== arr[i]) {
            return false;
        }
    }
    return true;
}

const array1 = [1, 2, 3];
const array2 = [1, 2, 3, 4];

console.log(array1.isEqual(array2)); // This would incorrectly return true without length check

In this example, without checking the lengths, the isEqual method would compare the elements [1, 2, 3] in array1 with [1, 2, 3, 4] in array2. The loop would iterate three times, find matching elements, and return true, even though the arrays are not equal.

Readme file

ln 3,Col 35 in Read me it should be ES5

Practice: ES5 Classes

In this practice, you will use ES6 class syntax to define classes and
monkey-patch an existing class.