apoca / lambda-resize-image Goto Github PK

I want to use this repo but i can not see the automatic tests. you will make this in near future?

2018-10-10T15:27:48.232Z 0ad4817a-cca1-11e8-b8ac-6df64c340e00 TypeError: Cannot read property '0' of null at /var/task/src/handler.js:1:3502 at h (/var/task/src/handler.js:1:3506)

I am facing an issue with domains with the path (basename). Our script only support one level:

Example: http://api.example.com/<YOU_KEY_NAME_S3_HERE>?width=150&height=150

const path = event.path;
const imageKey = url.parse(path).pathname.replace(/^\//g, '');

The above code with "replace" will work as supposed. But, whether we have more than the YOU_KEY_NAME_S3_HERE, as http://api.example.com/development/service/<YOU_KEY_NAME_S3_HERE>?width=150&height=150 we'll get an error. Obviously, because our url have more than the KEY_NAME, it have also "development/service/".

Max with image should be 1800px
Max height image should be 1800px

If key does not exist should return 404

This repository is working well for the first version. However, after some time our website is growing and we are facing now some issues with the speed page, we have implemented the CDN, but we have some issues with redirects...

resolve({
      statusCode: 301,
      headers: {
        Location: `${process.env.URL}/${key}`
      }
});

Getting a type error - cannot read property 'length' of undefined when trying to deploy - tested locally and works.