Coder Social home page Coder Social logo

veriff-challenge's Introduction

VERIFF CHALLENGE

Hello guys! Thanks for opportunity, i am very happy with the idea that we could work together soon!

Before you take the code, i have some considerations here:

  1. Actually i am working a lot in new projects for Avenue Code/MZ GROUP, my actual job, including WEEKENDS with studies and new deadline challenges, so i take your challenge in the weekend, using every free second that i had focus on MUST TO HAVE actions to send you this on monday and i think we have a good code here! It was a good challenge, thank you!

  2. I started using the best practices of OOP and SOLID principles thinking about scalability, maintenability and clean code.

  3. The tests are simple, but with 83% coverage, with all locally mocked(you can do this in a local machine without internet connection) but off course we can improve the tests in number and complexity.

  4. About performance, using OOP and SOLID the eprformance increase in 9% in the total time spent between original app and actual app. You can check the original app performance here: https://colab.research.google.com/drive/1fpC61Wf7qUD1m-35TnQ09WcGRadXkt1Z?usp=sharing and in file called "Veriff_Challenge_compare_apps_performance.jpynb" on this repository. Docker decrease a lot the performance but we can take the same 9% increase with it too.

  5. I used logging info to put logs inside birdclassifier.log(started with init() of ImageClassifier).

  6. Tensorflow warnings about gpu/cuda and saver can be solved so this will be a good future improvement.

  7. Docker will be a good improvement but this is a NICE-TO-HAVE in tasks description(bonus) so i focused on do my best with time i have for now and i think we have a good delivery here, can you send some feedbacks about it? thanks!

Local setup

  1. Install docker if you dont have it

  2. Run container with docker build -t bird-classifier . on terminal

  3. Run application with docker run -t bird-classifier

veriff-challenge's People

Contributors

apenasweber avatar

Watchers

Rivo Laks avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.