antonsamper / hapi-cron Goto Github PK

Hey,

Could you please publish the new version to NPM please ?

• Updated Node version to LTS v12.x
• Update dependencies

The devDependency @hapi/eslint-plugin-hapi was updated from 4.3.3 to 4.3.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@hapi/eslint-plugin-hapi is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Add files prop to package.json and include only neccesary files. Remove tests, eslint, travis etc.

The devDependency hapi was updated from 17.6.1 to 17.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

hapi is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Version 17.5.3 of hapi was just published.

This version is covered by your current version range and after updating it in your project the build failed.

hapi is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

"Shot" is no longer being used in tests so it can be removed as a dependency.

Cron jobs are currently starting as soon as the the plugin is registered. This was an oversight as opposed to intentional functionality.

As suggested by @Marsup outmoded/hapijs.com#465, it would be better to start the jobs when the server actually starts onPostStart, and equally stop them before the server stops onPreStop .

Reference: https://hapijs.com/api#serverextevents

The devDependency @hapi/eslint-config-hapi was updated from 12.1.1 to 12.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@hapi/eslint-config-hapi is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The dependency hoek was updated from 6.0.4 to 6.1.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

hoek is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await, as well as deprecating some other rarely used functionality. This is a breaking change that may make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: hapijs/hapi#3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

• Reply to this to acknowledge that you are actively maintaining this module and are willing to update it
• Update plugin to be fully async/await compatible using the v17 branch from Hapi for testing

  Possible dev flow for updating

  • Clone Hapi
  • npm link within the Hapi repo
  • npm link hapi within your plugin repo
  • Your plugin will now be using v17 of Hapi branch for tests
• Release new major version of your plugin on npm. Please use a major version increment as this will be a breaking change and it would be terrible for it to sneak into current versions of Hapi.

Notes

• Support is being dropped for all versions of Node <8.0.0.
• Hapi v16 will continue to be supported for as long as there exists a Node LTS actively being supported that is not compatible with v17.
• Targeted release date is November 1st, 2017. Please try to have your plugin updated before then.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

The devDependency shot was updated from 4.0.6 to 4.0.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

shot is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The dependency cron was updated from 1.5.0 to 1.5.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

cron is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The documentation for this plugin says

onComplete - Function to run after the route has been requested. The function will contain the response from the request 

but it doesn't appear that anything is being passed to the onComplete function. Is this an oversight or is there some other way I am supposed to access the res from the request in the onComplete?

this job always logs undefined no matter what I respond with from my route

jobs: [{
            name: 'Refresh Credentials',
            time: '0/10 * * * * * ',
            timezone: 'Europe/London',
            request: {
              method: 'GET',
              url: '/api/auth/credentials',
            },
            onComplete: (response) => {
              console.log('response', response)
            }
          }],

Right now the plugin requires that the route of the CRON job is public. However for most CRON jobs the route should not be accessible to the outsite world especially since most of them are using also auth: false . The problem is that if we declare the route as isInternal: true the plugin would not be able to call it since the inject method does not have its option allowInternals: true :