Coder Social home page Coder Social logo

Comments (5)

antonmedv avatar antonmedv commented on May 23, 2024

FireFox, mehh. As usual.

Any volunteers to find regression bug between versions?

from codejar.

Creekmind avatar Creekmind commented on May 23, 2024

Hi!

Issue with restore(save()) inside keydown listener. It was added in PR: #49 .
But I don't get it why it is there, because everything seems working without this line. I am missing something

@zamfofex need help :)

...
if (isLegacy) restore(save()) // Legacy is false for chrome
...

from codejar.

antonmedv avatar antonmedv commented on May 23, 2024

It will really awesome if we can add tests in GitHub action with real firefox and chrome.

from codejar.

zamfofex avatar zamfofex commented on May 23, 2024

From the PR description:

Work around seemingly buggy selection behavior in Firefox when nodes are swapped around. It seems Firefox doesn’t like when nodes containing the selection are replaced entirely while the user is manipulating the selection, and it will reposition the selection in weird ways immediately before the keyup event is dispatched. Modifying the selection seems to suppress this behavior, so it suffices to write restore(save()) during the keydown event dispatch.

It is not impossible (and is actually very likely) that Firefox simply resolved that “seemingly buggy behavior” since that time.

from codejar.

Creekmind avatar Creekmind commented on May 23, 2024

@zamfofex Yes, I read it. Do you have project/jsfiddle, where I can reproduce it?

from codejar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.