antonio32a / lilyweight

Hypixel SkyBlock Weight Calculator

Hey there, I'm Antonio32A

I'm a Java/Kotlin Software Developer which mostly works on Minecraft related stuff.

I make mods, plugins, Discord bots, ChatTriggers modules and lots of other fun stuff.

Contact

[email protected]

lilyweight's Issues

Catacombs Completion Pushing NaN

I keep throwing an error where I am getting NaN for catacombs completions. For both base and master.

@Antonio32A @Desco1 @LappySheep @nstringham

cannot use getWeightRaw without api key

getWeightRaw doesn't require an api key but it can only be accessed by calling the main export

dugneonCompWeight returns NaN when passing M7 value

dungeonCompWeight.js is returning NaN when passed a value for M7 completions.

I didn't test but it's most likely due to the missing value for M7 in this array:

lilyweight/lib/constants.json

Lines 68 to 83 in 59106dd

	"dungeonCompletionWorth": [
	0.0827,
	2.1034,
	4.5966,
	7.9383,
	13.4018,
	23.1071,
	43.7857,
	63.3437,
	29.048912,
	38.548912,
	51.623912,
	67.004212,
	75.233412,
	99.17424
	],

Carpentry skill missing

As of update 0.14, the Carpentry is no longer a cosmetic skill and is officially counted towards skill average. As such, it should be included in the weight calculation.

Weight changes

Lily did some nerfs today that need to be ported to this repository

Potential security risk by exposing API key

Currently if you have an object of the LilyWeight class the apiKey class field is accessable by any code that has a reference to the object.

This is a security regression caused by #4

I recommend fixing this by using private class fields.

I can make a PR for this later but right now I am busy with Final exams

types missing for m7?

lilyweight/lib/index.d.ts

Line 28 in a390471

mCataCompl: {"1": number, "2": number, "3": number, "4": number, "5": number, "6": number},

Seems like types for mCataCompl are missing the 7th floor