antoinerrr / dehyrated-pdns Goto Github PK

Hello!

I'd like to suggest making two edits to this:
while ! dig @8.8.8.8 -t TXT _acme-challenge.$domain | grep "$token" > /dev/null

first, use +trace and +short instead of 8.8.8.8, because 8.8.8.8 caches stuff,
and use grep -- "$token", because the tokens sometimes start with -.

Works fine with .com, doesn't work with .co.uk.

If script is run from a different directory, or out of cron, the config file isn't found.

Script can fail if mysql loginpath config exists with conflicting values as they take priority. For example if you have ~/.my.cnf with a password set this will override the config written out and read by the script.
Quick fix is to use --defaults-file instead of --defaults-extra-file.

pdns table names hardcoded, should be variables

Mysql values hardcoded into script, would be nice to be able to have a config file holding these values instead of hacking script.

letsencrypt.sh has been renamed to dehyrated for copyright/trademark reasons. This project should be renamed to reflect that.

https://doc.powerdns.com/md/authoritative/backend-generic-sql/#autoserial

You can set the serial value to 0 in the soa record to let powerdns automatically increase the serial in SOA responses.
This script will update the soa record and change the serial to 1.