anthyg / da_cards-2

A Online Card-game, based on NodeJS, socket.io, and React.

da_cards-2

A Online Card-game, based on NodeJS, socket.io, and React.

da_cards-2's Issues

use-async-requests :: Card-property loading bug

Card-properties don't get correctly loaded in the Card React-component, when the properties haven't yet been loaded from the Server, resulting in animations in the draw-function of CardFace for a Card being set to undefined, thus crashing the draw-loop of the CardFace.

I probably need to re-write the stuff in the componentDidMount and render functions of Card, to be able to fix this.

Card-Faces stay applied, even after their type has changed to null

Host-Change causing problems with sendGame

It seems, that when both players reload their page, and join back in again, but in the "wrong" order, the host changes, causing some problems in the game-data getting sent to them respectively by the server.

Implement isLoggedIn- and isInGame-Check

As this is currently missing, every socket.on server-side is vulnerable to being called by a user, not in-game, which generates an TypeError, thus crashes the server.

This can also be somewhat-prevented by solving issue #2

Responsive-design stuff

ExpressJS-Session, to stay logged in after Server-restart

As #4 is closed, but there was another good idea there, I'll create a new one from that:

The isLoggedIn-check could also be achieved via an ExpressJS-session.
See this article for further information, on how to achieve something alike.

GID in URL

This could be useful for viewing running games and viewing/sharing results, when a game is finished.

Rewrite all css with scss

Self-explanatory.

Server-restart/ Connection-fail: What should happen?

The client could just try to log-in again

Also, in future, the userlists won't just be an object in the server, but a real database, so that will prevent pretty much everything from being erased.