anthill / 6bin Goto Github PK

https://github.com/tshelburne/redux-batched-actions

Yesterday we had a bug on 6element and bin couldn't be retrieved. So we changed stuf and pressed many times on the retry button. But this button can be pressed so easily that it costed us 9.5euros:

I think we should at least impose a limit to number of times it can be pressed per minutes.

It should be the same as .gitignore, including .js but excluding .ts

Check with @DavidBruant if there is a better way to access waste-categories
https://github.com/anthill/6bin/blob/master/ts/server/main.ts#L31

Action history is easily implemented into a Redux app: http://redux.js.org/docs/recipes/ImplementingUndoHistory.html

We should use this to be able to revert to a prior state when an operation timed out when trying to access kerrigan server.

Since there is a prepublish script that compiles basically everything, dependencies are not needed...
Is it a good choice ?

https://www.chromium.org/developers/how-tos/run-chromium-with-flags
http://peter.sh/experiments/chromium-command-line-switches/

Consider the following flags:

• --safebrowsing-disable-auto-update "If present, safebrowsing only performs update when SafeBrowsingProtocolManager::ForceScheduleNextUpdate() is explicitly called. This is used for testing only."
• --bwsi "Indicates that the browser is in "browse without sign-in" (Guest session) mode. Should completely disable extensions, sync and bookmarks."
• --disable-background-networking "Disable several subsystems which run network requests in the background. This is for use when doing network performance testing to avoid noise in the measurements."
• --disable-extensions "Disable extensions"
• --disable-sync "Disables syncing browser data to a Google Account."
• --no-experiments "Disables all experiments set on about:flags. Does not disable about:flags itself. Useful if an experiment makes chrome crash at startup: One can start chrome with --no-experiments, disable the problematic lab at about:flags and then restart chrome without this switch again."
• --no-first-run "Skip First Run tasks, whether or not it's actually the First Run. Overridden by kForceFirstRun. This does not drop the First Run sentinel and thus doesn't prevent first run from occuring the next time chrome is launched without this flag."
• --no-pings "Don't send hyperlink auditing pings"
• --kiosk

Interesting, but not sure:

• --disable-quic "Disables support for the QUIC protocol."
• --disable-infobars "Prevent infobars from appearing."

Maybe it would interesting to have a store on 6bin server, with only bins and recycling_center infos. This could have some benefits regarding data transfert between 6bin client and kerrigan server.

A 'init mode' needs to be implemented

• The user has a one-click button to notify the recycling center is closed for today
• The user can modify the recycling center regular hours
• The user can modify the recycling center hours only the this week and the next one (special modification)
• The user can list upcoming days when the recycling center will be closed exceptionally and provide a description of why (this message will be shown on the citizen phone, warn about this in the UI)

Let's make a component that takes a list of bins (name, number, image url) and triggers 2 redux actions (one to notify emptiness, the other fullness).

in server/src/main.js, i try to log the size of an Immutable List<BinData>.

console.log('SAVING BIIIIIIIIINS !!!', data.action.bins.length, data.action.bins.size);

I get a TS warning: server/src/main.ts(46,60): error TS2339: Property 'length' does not exist on type 'List<BinData>'.
The length outputs the correct length, while size outputs undefined...

This can be very useful to communicate with the operator in case of bugs. (happened this morning).

Bin list doesn't have any ordering by now, expect the order of addition which bugs when the list is split into 2 lines.

We should display something to warn the user that 6bin is usable when 6bin server / 6brain has a problem.
It should be a display mode where the user can't do anything with the interface

This can lead to switching on and off bins unnecessarily.

and report the results to 6brain, which will send the global results once per day

There is a promise Map in serverLink whose purpose is to resolve the correct promise when coming back from server.
There is also a pendingAction Map in the client Store, to warn the user some actions are still pending.

Currently, the indexes are different, but should probably be the same.

https://github.com/facebook/react-native/blob/3a92f2017fc2e51c2a915f0e535397cb3937d412/local-cli/server/util/debugger.html#L15

This is so very wrong, the port is now passed to the server as parameter through 6brain. It works for now because the PORT.js file still exists due to previous versions (wasn't deleted), and because we haven't changed the port. But this might be a problem in the future.

https://github.com/anthill/6bin/blob/master/ts/client/serverLink.ts#L8

We might need to go back to hardcoding the PORT for everybody, not passing it as a parameter.

• remove the chrome notification (like translate, restore session...)
• remove the mouse icon