Report issue with fritz gui about tch-nginx-gui

[nclmrc]

If I click on language select there's a problem on the screen

[seproDev]

@Ansuel Could you provide a screenshot and browser/os you tried it on?

On my end it looks like this:


As soon as there is enough space a new column gets added.

[seproDev]

@nclmrc Could you proveda screenshot and browser/os you tried this on?

This is how it is supposed to look:

[emax810]

@sepro If I use Safari (11.1.1), not show cards on homepage : No problem with Chrome : Thank you ! Manu Inviato da  Mail

…

Il giorno 24 apr 2018, alle ore 10:48, Sepro ***@***.***> ha scritto: @nclmrc <https://github.com/nclmrc> Could you proveda screenshot and browser/os you tried this on? This is how it is supposed to look: <https://user-images.githubusercontent.com/4618135/39176392-01271dae-47ad-11e8-9959-ee073a83dcab.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AdpF67M5uCBZNiDdMe2Mrwjyl3ABvf3wks5trub5gaJpZM4TgxvU>.

[nclmrc]

@SeproDE i use Firefox. After click on language select.

[seproDev]

Those are the issues I was able to reproduce:

• openNav is being called while in desktop view when clicking a select Element
• No visible cards on Safari (at least on my iPad i was still able to interact with them). I found out why they are invisible. Safari treats the overflow property different then other browsers. If i add overflow: visible !important; the cards are visible but the sidemenu is broken. I found a way to make it partially work. On mobile the openNav() and closeNav() function change the scroll property and on larger screens Safari (at least the iOS variant) will have a broken sidebar.
• On Edge modal footer and header are not at there right position.
• Internet Explorer doesn't limit width of sidebar
• Internet Explorer and iOS Safari title is not centered
• (partial fix) Footer not visible due to vh on mobile.
• switches in side menu getting moved outside
• On Edge fixed elements are jumpy. This is a know issue in Edge and supposed to be fixed with the Spring Creators Update
• On Edge transform on fixed while scrolling looks buggy
• nav-tabs overflow
• Mobile view and scrolling via transform on fixed elements not working on Internet Explorer. Something keeps the Javascript from running.
• Scrolling performance is very bad on mobile devices
• Tiles not clickable on mobile
• iOS grey overlay not visible

I will see what I can fix. If I found a solution I will mark them off.

If you found a fix, post either the snippet here or create a pull request.

[seproDev]

@nclmrc I just created a pull request with a couple of bugfixes. Should be fixed.

[seproDev]

@emax810 This is caused by the way Safari Interpreters the overflow property and how we want a scrollbar for the sidemenu but fixed elements (that we later move) outside the sidemenu.

As far as I can tell there are two options for Safari: either we have a scrollbar for the sidemenu or we have cards.

This is the new behaviour i came up with:

• On mobile the sidemenu is not visible at the same time as the cards. So Javascript takes care of applying the right overflow property.
• On desktop this piece _::-webkit-full-page-media, _:future, :root of css hell will (hopefully) show cards but break the scrollbar in Safari while changing nothing for other browsers.

[Ansuel]

can you find a way to enable the aos animation

the loading animation doesn't show when the loading page is shown

[nclmrc]

Scroll until the end of the page doesn't work in some tab in desktop mode

[seproDev]

@Ansuel I don't think it's easily possible for the card's since they already have a transform property applied to them. For the modal view I have to say that i quite like the snappy feeling of not having to wait the 0.3 seconds until the animation is finished.

[seproDev]

@nclmrc Could you provide some more information like browser and OS?

[nclmrc]

@SeproDE Google chrome on android

[seproDev]

@nclmrc Could you give some instructions for how to replicate the bug.

The only thing I was able to find out is that if the screen size varies the modal view has the wrong size and with that the footer may be lost:

But I don't think this is what you meant.

[nclmrc]

[seproDev]

@nclmrc Okay, thank you for reporting this. I was able to fix it, but this breaks something on iOS. Once I figure this out I will create a pull request.

[nclmrc]

the problem instead on firefox on windows 10 when i select language with teh arrow

[seproDev]

@nclmrc I spend the better half of today investigating this issue, with many different possible solutions. Each one breaking something else...

Here is the basic rundown:

The problem occurs because I use max-height: 100vh; on the modal-body (I actually use calc() to also subtract a fixed value but that's besides the point). On mobile devices the vh unit represents the larger viewport (the one without the address bar) and not the currently active one. This is intentional behaviour and was copied by the Chrome team from iOS (more info).

The obvious answer would be to switch to max-height: 100%; and that works great on mobile and every browser I tried except Google Chrome Desktop. Chrome let's the element just overflow, which disables scrolling. This is also by design, because Chrome takes as a reference for 100% not the viewport but the parent element and since this element has height: auto;, max-height computes to none. (more info)

Setting the height to a fixed value is also not possible since the height is dependent on the content inside.

I have also tired applying max-height: 100vh; to Chrome Desktop and max-height: 100%; to everything else, but every CSS-Hack I tried applies to both Chrome variants.

As far as I can see there are two options now:

1. Modal-footer at wrong position when address bar is hidden on Chrome for Android in forced Desktop mode.
2. Always maximum size modal view on all browsers.

I would decide for number 1. But maybe I am wrong and there is a third option.

Im just an amateur having a bit of fun with CSS. If anybody knows of a solution to this problem: please share it.

[nclmrc]

@SeproDE in mobile view when I click on tab hasn't effect.

[nclmrc]

Chrome on android

[nclmrc]

Qualcuno riporta ancora problemi su questo tema?

[FrancYescO]

controllai qualche release fa e gli ultimi problemi segnalai c'erano ancora

[seproDev]

I really like the new stats page. Thought it should be visible in the cards section and since the original Fritz Cards werent that usefull I decided loading the stats page via a iFrame should closere resemble the original Fritz!Box ui. Here is what i made so far: Click

Please leave feeback before I create a PR. Should this be a seperate style or a update to the old one?

[Ansuel]

Can you give me a screenshot? Il Ven 5 Ott 2018, 11:50 Sepro <[email protected]> ha scritto:

…

I really like the new stats page. Thought it should be visible in the cards section and since the original Fritz Cards werent that usefull I decided loading the stats page via a iFrame should closere resemble the original Fritz!Box ui. Here is what i made so far: Click <https://github.com/SeproDE/tch-nginx-gui/tree/master/decompressed/gui_file/www/docroot/theme/Fritz> Please leave feeback before I create a PR. Should this be a seperate style or a update to the old one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATWWQjkgN_P7XI2YOA64IdHGix_4LBBjks5uhytmgaJpZM4TgxvU> .

[seproDev]

update:

[FrancYescO]

@SeproDE i like it, do a PR

[FrancYescO]

in some modals (where there is a button or something with a tooltip text) under the modal, cards will be shown behind the modal after you hover on the button.
fo example just go to the telephony modal and hover (and take the mouse out) on the bottom righ edit button

when you hover and go out from the button:

when you hover again:

[seproDev]

Fixed! Created a PR.

[FrancYescO]

can we put a loading spinner when "processing" (for example the one that appear on the end of wizard)

[seproDev]

What Browser/OS and what Tab is the spinner not showing? This is how it looks in Chrome on Windows 10

I think this was one of the things i fixed along the way. Try it with the Version from the PR.

[FrancYescO]

Same W10 Chrome, tryed a cache clean and just the first time the spinner is shown if i click again (on relay tab for example) the processing page is just blank, pretty strange

[FrancYescO]

ps. can we remove the animation on the lateral menu? really boring that i have to wait the full page load (jquery event fired?) to see it

[seproDev]

I think you are still running the old version. Try runnning the style version from my PR. Then the spinner should always be shown.

Regarding the animation. It's possible to just force the end state of the animation via the !important tag. Not pretty but it works.

[FrancYescO]

Some mobile issue I noticed:

• Login page looks broken
  
• the bottom bar with the close button cover some content of the modal (an easy fix can be to move the close button in the upper light blue bar)
  

[FrancYescO]

can we remove the giant word "TIM Modem" as a lot of us are not using a TIM modem? :D

Also the issue from #38 (comment) is still not solved, we need some sort of horizontal scrolling for tabs

[dga4130-renato]

Device Model: DGA ( DGA4132 )
Gui Version: 8.8.99

Description of problem:
On dark/midnight theme no diagnostics icons in main menu, only if you hoover on the icon displays
new version but bug still here

[kevdagoat]

any news on this?

[seproDev]

Well the question is if we want to have the dark skins as a separately developed fork or as an add on to the Fritz theme.
If its the first this should be separately fixed if its the second someone need to port the changes I made to the Fritz skin to the other two skins.

[Ansuel]

Back theme share the same script.js so only the CSS should be rebased... Il giorno Gio 1 Nov 2018, 09:49 Sepro <[email protected]> ha scritto:

…

Well the question is if we want to have the dark skins as a separately developed fork or as an add on to the Fritz theme. If its the first this should be separately fixed if its the second someone need to port the changes I made to the Fritz skin to the other two skins. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATWWQq26ya9kMVvXFc8XgAlTdHOnJnVgks5uqrWygaJpZM4TgxvU> .