Coder Social home page Coder Social logo

Comments (2)

axelboc avatar axelboc commented on June 2, 2024 1

Regarding the scope, I would limit ourselves to "both flags exist and are commonly used".

To decide this, perhaps we could compare multiple sources like Larousse, Britannica, etc. (cf. #111) and include both flags when at least one source differs?

I would argue that we should also specify that the civil and state flags must differ significantly (e.g. at least one "major" difference). This will avoid including Belgium or trying to figure out if one of the sources uses the civil or state flag, which is not always obvious when only the size or colour differs.

Adding this to the extended deck is not a bad idea. This is quite niche after all. Moreover, extended deck users most likely use CrowdAnki already and won't be as scared of seeing the note model merger pop-up, which would make adding one or two new fields less of a con.

Do you think we could find a way to add a single field with only the alternative flag? Could the template somehow infer the text to display (civil/state) from the filename of the alternative flag?

from ultimate-geography.

aplaice avatar aplaice commented on June 2, 2024 1

To decide this, perhaps we could compare multiple sources like Larousse, Britannica, etc. (cf. https://github.com/anki-geo/ultimate-geography/issues/111) and include both flags when at least one source differs?

That should work! Britannica, Larousse and the two Wikipedia articles should hopefully be sufficient. (Having more allows us to be less affected by edit wars on Wikipedia — what do we do when Wikipedia is the outlier (say the only one with the civil flag) and flips (say to displaying the state flag)? — but is also more tedious to implement.) (If we go "wide" in sources, maybe we could also use FOTW as one?)

Do you think we could find a way to add a single field with only the alternative flag? Could the template somehow infer the text to display (civil/state) from the filename of the alternative flag?

That's a brilliant idea! :) It should be doable with pure CSS (with a combination of img[src*="-civil"] and ::before or with invisible elements made visible with sibling combinators ~). The disadvantage is that the text wouldn't be translated (but then "Flag similar to" is also currently not translated).

from ultimate-geography.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.