Project looks very interesting, but why use limiting at the app instead of reverse proxy like nginx? about node-rate-limiter-flexible

[samuelgoldenbaum]

Thanks for the reply @animir, I am sure there is value in the project and appreciate your contribution to the OS community.

[animir]

@samuelgoldenbaum hi, thanks

nginx proxy with configured limit is better, if it is enough. any proxy, balancer is better to be honest
use this package only if you can not find other proxy/balancer solution.

yes, app is still caught up processing rate limiting, as you said. it is not big, you can get overall idea checking benchmark results on high traffic or test it in your environment. usually it is nothing, if request takes 3-15 ms more. rate-limiter-flexible can be used in applications with thousands of requests per second. Usually, such applications have much more issues than saving 3-15 ms per request.

The idea of creating new app layer with just rate limiting on nodejs in front of application, may be good. It depends on certain environment. Superficially, if your app is monolith, I don't thing it is good to implement new layer. If your app built as microservices, probably, it is good idea to extract limiting to separate nodejs app.