Coder Social home page Coder Social logo

Comments (7)

paulsc54 avatar paulsc54 commented on May 27, 2024 1

Ok great.

Certainly, I just need to carve out some time, and I'll get to work on it.

Thanks! I'll keep you posted

from node-rate-limiter-flexible.

animir avatar animir commented on May 27, 2024

@paulsc54 Hi, thanks for the bug report.
I am not quite familiar with how postgres works with database and table names.
Would separate dbName option be helpful here? In this case it could be part of query like this ${dbName}.${tableName}.
Could you help with defining the right approach for postgres? Thanks.

from node-rate-limiter-flexible.

paulsc54 avatar paulsc54 commented on May 27, 2024

Double quotes are used to indicate identifiers within the database (tables, column names, roles, etc.). Therefore schema and database names have to be used as distinct identifiers. To enhance clarity, consider introducing a new parameter, schemaName, and employing it in this manner: ${schemaName}.${tableName}. (btw the parameter could be optional as by default postgres will target the public schema).

Regarding the dbName you referenced, its role doesn't extend to becoming a part of the query. Once the connection is established with the driver, the accessed database is implicit. Hence, our focus remains on specifying the schema and table.

from node-rate-limiter-flexible.

animir avatar animir commented on May 27, 2024

@paulsc54 Ok, thank you.
We should introduce new parameter schemaName, so it would be clear for postgres users.
As a temporary fix you can downgrade the package to version 3.0.0.

Would you be able to make this fix?

from node-rate-limiter-flexible.

paulsc54 avatar paulsc54 commented on May 27, 2024

Just created #227.
I ran some tests on my local setup with Postgres, and everything appears to be in good shape.

Just make a few tweaks—nothing too extensive. That should get the job done.

from node-rate-limiter-flexible.

animir avatar animir commented on May 27, 2024

@paulsc54 Thank you!
I merged the PR.

The new version 3.0.2 published.

from node-rate-limiter-flexible.

paulsc54 avatar paulsc54 commented on May 27, 2024

Amazing. Thank you!

from node-rate-limiter-flexible.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.