Comments (7)
Ok great.
Certainly, I just need to carve out some time, and I'll get to work on it.
Thanks! I'll keep you posted
from node-rate-limiter-flexible.
@paulsc54 Hi, thanks for the bug report.
I am not quite familiar with how postgres works with database and table names.
Would separate dbName
option be helpful here? In this case it could be part of query like this ${dbName}.${tableName}
.
Could you help with defining the right approach for postgres? Thanks.
from node-rate-limiter-flexible.
Double quotes are used to indicate identifiers within the database (tables, column names, roles, etc.). Therefore schema and database names have to be used as distinct identifiers. To enhance clarity, consider introducing a new parameter, schemaName
, and employing it in this manner: ${schemaName}.${tableName}
. (btw the parameter could be optional as by default postgres will target the public schema).
Regarding the dbName
you referenced, its role doesn't extend to becoming a part of the query. Once the connection is established with the driver, the accessed database is implicit. Hence, our focus remains on specifying the schema and table.
from node-rate-limiter-flexible.
@paulsc54 Ok, thank you.
We should introduce new parameter schemaName
, so it would be clear for postgres users.
As a temporary fix you can downgrade the package to version 3.0.0
.
Would you be able to make this fix?
from node-rate-limiter-flexible.
Just created #227.
I ran some tests on my local setup with Postgres, and everything appears to be in good shape.
Just make a few tweaks—nothing too extensive. That should get the job done.
from node-rate-limiter-flexible.
@paulsc54 Thank you!
I merged the PR.
The new version 3.0.2
published.
from node-rate-limiter-flexible.
Amazing. Thank you!
from node-rate-limiter-flexible.
Related Issues (20)
- BurstyRateLimiter.get( key ) throws error when key doesn't exist yet HOT 2
- TypeError: Cannot read properties of null (reading 'points') using mongoose HOT 9
- Redis configuration
- Run test using github actions HOT 1
- Lua script takes non integer argument as input which causes random error on user supplied input HOT 6
- Lua Script uses only Write commands and Cannot Scale in a Redis Cluster HOT 9
- Rate limit redis - Express middleware HOT 7
- Redis limiter on version 3.0.2 TypeError: Invalid argument type TypeError: result is not iterable HOT 2
- RateLimiterMemory blockDuration doesnt work with 1 billion seconds HOT 4
- rateLimiter.get always returns `null` HOT 4
- Usage with Prisma ? HOT 2
- RateLimiterMemory msBeforeNext is negative in Vercel edge function HOT 8
- PM2 cluster error "timeout: no answer from master in time" if the master is not already available when the client is created HOT 2
- consume() vs penalty() HOT 1
- Very large bundle size HOT 12
- RateLimiterMongo TypeError: Cannot read properties of null (reading 'value') HOT 1
- [Feature Request]: Don't Throw Errors When `limiter.consume()` Rejects a Request from a User HOT 4
- How to prevent negative values HOT 2
- Dynamo this.client.updateItem is not a function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-rate-limiter-flexible.