Coder Social home page Coder Social logo

Put glfw under subrepo about vookoo HOT 8 CLOSED

FunMiles avatar FunMiles commented on June 25, 2024
Put glfw under subrepo

from vookoo.

Comments (8)

FunMiles avatar FunMiles commented on June 25, 2024

I have created a first basic version with glfw clone into the external directory.
Can you check it out on windows, @lhog ? I have checked it also works on my Linux box.
https://github.com/FunMiles/Vookoo. Branch glfw-subrepo

The changes also address #16

from vookoo.

andy-thomason avatar andy-thomason commented on June 25, 2024

Bear in mind that GLFW only exists to run the examples and is not a dependency of Vookoo itself (vku.hpp) which is dependant only on the Vulkan headers. However, we need an example framework to get us started - if only to create windows on three disparate platforms. I am not averse to using subrepos however, but we must document them carefully so that a new user who wants to run the examples will know how.

from vookoo.

FunMiles avatar FunMiles commented on June 25, 2024

@andy-thomason So far, my CMakeLists.txt in the main directory only supports the building of the examples. I intend to add an install capability, but perhaps as a separate pull request, as to keep issues well separated. In the install capability, it will create cmake files. The cmake file would allow to use find_package(vookoo) and they could have two components, the base one for vku.hpp and the framework one for vku_framework.hpp. The first one would add no dependency, but the second could carry with it the glfw dependency. Maybe we can have a discussion about this in a separate issue about installation. I can also amend the README.md to cover the subject of the examples. It already does say clearly that it is an include-only library.

In the mean time, do you think the building of the examples should be under a CMake option? Should it be on or off by default?

from vookoo.

lhog avatar lhog commented on June 25, 2024

Didn't work for me out of the box:
image

from vookoo.

FunMiles avatar FunMiles commented on June 25, 2024

@lhog, I rebooted my linux machine under windows and it works without trouble. Did you, by any chance, keep your build to point to the example as the CMake root directory? You need to select the main directory as the location of the CMakeLists.

from vookoo.

lhog avatar lhog commented on June 25, 2024

@FunMiles yep, apologies, I missed the fact you added another CMakeLists.
Works for me now too.

from vookoo.

FunMiles avatar FunMiles commented on June 25, 2024

Great. I'm creating the pull request.

from vookoo.

FunMiles avatar FunMiles commented on June 25, 2024

The PR has been merged. I'm closing this issue.

from vookoo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.