Packets to Implement

Packets\EntityEquipmentPacket (S)
Packets\PlayerDiggingPacket
Packets\HoldingChangePacket
Packets\UseBedPacket (S)
Packets\PlayerActionPacket
Packets\PickupSpawnPacket (S)
Packets\CollectItemPacket (S)
Packets\SpawnGenericEntityPacket
Packets\SpawnMobPacket
Packets\SpawnPaintingPacket
Packets\DestroyEntityPacket
Packets\UselessEntityPacket
Packets\EntityRelativeMovePacket
Packets\EntityLookPacket
Packets\EntityLookAndRelativeMovePacket
Packets\EntityStatusPacket
Packets\AttachEntityPacket
Packets\BulkBlockChangePacket
Packets\BlockChangePacket
Packets\BlockActionPacket
Packets\ExplosionPacket
Packets\SoundEffectPacket
Packets\EnvironmentStatePacket
Packets\LightningPacket
Packets\OpenWindowPacket
Packets\CloseWindowPacket
Packets\ClickWindowPacket
Packets\SetSlotPacket
Packets\UpdateProgressPacket
Packets\TransactionStatusPacket
Packets\UpdateSignPacket
Packets\MapDataPacket
Packets\UpdateStatisticPacket

Clean up unstable parts of server

Packet reading of unsupported packets breaking (because of buffer not clearing)
Handle disconnect and reconnect of clients.

After running only 30 seconds, everything seems to slow down to a crawl. Packets get delayed. Let's pin-point where this is occurring! xdebug has recently released support for PHP 7 in a beta release. So it may be worth looking into for profiling.

time based on microseconds:

Here, you can see places where I'm moving around, creating lots of packets, which spikes it up 1200 μs (barely anything)

WritePacket procedure looks normal:

Rolling Loop HandlePacket measures the time between each handlePacket.

Everything looks stable so far. Nothing to cause such a huge slowdown/delay.

PHP Issues/Painpoints

Some points to talk about in a post-mortem blog post:

Classes And Namespaces

This was a fun one to get my head wrapped around. PHP's namespacing isn't "bad". But it's also not good. Part of why it's not so great is probably due to "internal" PHP ideology, or perhaps wasn't well implemented.

You have to specify a file and require it one by one. (Or take the time to make an autoload script.) And then you have to also declare the namespace. It seems a bit redundant, but that may just be my "high-level programmer" spoiledness with having everything imported automatically. ;)

In some ways, I can understand why you would want to import each file one by one. It makes sure you know what namespaces you're importing. But also, I really just wish there was a wildcard import.. ):

C-style, C-libraries, but little C-positives?

What I find funny/awesome/strange is PHP's wrapping of C libraries. Reading the documentation, I can already see the comments that date back to 6+ years ago. Often times, I found it really helpful to just look at the C documentation itself. I would have really loved to see some primitive data types, like byte, short, int, etc.. but that's probably not possible. It's disappointing that they took these out. It makes handling binary/hex data so much harder due to the type of casting that PHP has.

And again with numbers, PHP's conversion is really lackluster and very questionable. hexdec()? dechex()? bin2unicorn()??? A strong foundation for these conversions would make lives so much easier.

PThreads

https://github.com/krakjoe/pthreads

Self-explanatory. I think it would be cool to build this with multithreading in mind. I do want SOME perfomance. :) #4

UPDATE:

pthreads has PHP7 support.

This better be fast.

Replace EventBuffer with something more supported / hand-coded buffer

https://github.com/andrewvy/HHVMCraft/blob/master/src%2FHHVMCraft%2FCore%2FNetworking%2FStreamWrapper.php#L24

It doesn't make sense to include these external dependencies when all I need is: EventBuffer

This may also be a bottleneck, I should really check performance numbers. But this is the only external package required, so removing it makes it easier to upgrade to PHP 7 when the time comes.

CI/CD to a Heroku Instance

Title! I'll buy a heroku instance and host a minecraft server instance. This will be nice for providing a fun testing playground when I'm live streaming development.

Replace ReactPHP with Icicle

https://github.com/icicleio/icicle

Let's try it out. The current implementation isn't too heavily dependent on ReactPHP. Mostly interested in Icicle's concurrency module.

Project name change

I'm considering a name change. What should I change to?

Proposals welcome. PR proposals also welcome. :)

server.properties

Implement server.properties

Refactor packet reading/writing

AGAIN WITH THE REFACTORING. I know this has been rewritten almost three times now.. but the string concatenation and multiple function calls to parse a packet is really wasteful and SLOW. We should be doing one pack statement, and one unpack statement. Easy.

Except we'll have to redo every packet that's been written so far. 👎

Example: http://systemsarchitect.net/parsing-binary-data-in-php-on-an-example-with-the-pcap-format/

UPDATE:

fyi, the new internal reading architecture should be client agnostic. The packet buffer should be Stackables in which pthread workers can chew on. We should probably do the same for outgoing clientbound packets, but I don't think that will be too much of a perf increase.

UPDATE 2:

check for inspiration at https://github.com/Poweruser/MinetickMod

Switch to PHP 7.0

This is a no-brainer, and since I'm not working on HHVM support currently (despite the project name). 💯

Better performance
Consistent 64-bit support (YES!)
Return types (Finally!)
and many other goodies that i'm excited for.

Let's see if switching will break anything major.

UPDATE:

Waiting on the event extension to be ported to PHP 7

https://bitbucket.org/osmanov/pecl-event/issues/17/support-php-7

Things to make functional demo

Required

Add EntityManager and create/manage player entities properly.
Add Block/Item Provider and all the blocks/items for lookup.
Add Region.
Add ChunkProvider.
Manage player inventories.
Send over compressed chunks.
Add Item NBT Data.
Add read/write floats and doubles

Packets

Switch to using EventBuffer

http://php.net/manual/en/class.eventbuffer.php

We should immediately copy from the socket's buffer into a client packet buffer, which we can have greater control over reading the bytes from.

http://php.net/manual/en/eventbuffer.read.php

FYI: ReactPHP Socket buffer size is 4096

Refactor to use built-in PHP Streams

http://php.net/manual/en/streamwrapper.stream-read.php

Seems easy and we won't have to manage a buffer and implement a pseudo-stream ourselves.

Not really related directly to your project but:

Ive been thinking for a while about making a c recreation of a mc server for beta, i wondered if you could tell me how you approached it and how you found out how packets and stuff work without the source code, because ive been trying to intercept packets with wireshark but all i could get was some hex data that is really hard to interpret, ty in advance.

Remove license information from all the code files

Reasons Why:

Irrelevant with license file in root
Same information in every single file that's unnecessary
Big projects no longer do this and it's old practice, even proprietary open source PHP applications too

Feel free to close this if you disagree.

Write some documentation for classes

I'll try and work on this tomorrow and will submit a PR when it's sorted.

Server CLI

When executing the script, it should open up a shell interface. Allows simple management commands like kick, ban, give, etc.

Create github.io development blog

Post stuff like https://www.youtube.com/watch?v=vfQ4bXN3oFk on there.

XDebug Profiling

Use XDebug to profile and generate flame graphs to pinpoint obvious speed bottlenecks. I don't want to focus too much on performance, but any chunk we can get along the way is added benefit. We definitely get slower and slower with parsing packets over time because our queue fills up.

We are getting bombarded with packets, it's crazily filling up our queue. There's gotta be a better way we can parse this out. Combined unpack statements rather than one by one? Something.

EDIT: xdebug is pending PHP 7 support.

Add Type Inference/Translation Class

????

PHP is not so great at diving into these different primitive types (It's very good at abstracting them all), we will need something to make it easy to pass in a string of bytes (ByteArray) and translate it into different types.

Post-completion Goals

Implement NBT saving/loading from disk.

Chunk Data Packet Problems

 0 : 33 00 00 00 00 00 00 00 00 00 00 09 7f 09 00 00 [3...............]
10 : 00 8d 78 9c ed cd 31 11 00 00 08 04 20 cf ef df [..x...1..... ...]
20 : d9 c5 0e 3a 40 01 92 d5 75 22 7e bf df ef f7 fb [...:@...u"~.....]
30 : fd 7e bf df ef f7 fb fd 7e bf df ef f7 fb fd 7e [.~......~......~]
40 : bf df ef f7 fb fd 7e bf df ef f7 fb fd 7e bf df [......~......~..]
50 : ef f7 fb fd 7e bf df ef f7 fb fd 7e bf df ef f7 [....~......~....]
60 : fb fd 7e bf df ef f7 fb fd 7e bf df ef f7 fb fd [..~......~......]
70 : 7e bf df ef f7 fb fd 7e bf df ef f7 fb fd 7e bf [~......~......~.]
80 : df ef f7 fb fd 7e bf df ef f7 fb fd 7e bf df ef [.....~......~...]
90 : f7 fb fd 7e bf df ef f7 3f f8 07 af 29 1d 01 [...~....?...)..]

This isn't working. It seems the client is reading it wrong. It seems like it's in the correct format though?

breakdown

Packet ID: 33
X: 00 00 00 00
Y: 00 00
Z: 00 00 00 00
Width: 09
Height: 7f
Depth: 09
Chunk Data Length: 00 00 00 8d (141)
Chunk Data:
78 9c ed cd 31 11 00 00 08 04 20 cf ef df d9 c5
0e 3a 40 01 92 d5 75 22 7e bf df ef f7 fb fd 7e
bf df ef f7 fb fd 7e bf df ef f7 fb fd 7e bf df
ef f7 fb fd 7e bf df ef f7 fb fd 7te bf df ef f7
fb fd 7e bf df ef f7 fb fd 7e bf df ef f7 fb fd
7e bf df ef f7 fb fd 7e bf df ef f7 fb fd 7e bf
df ef f7 fb fd 7e bf df ef f7 fb fd 7e bf df ef
f7 fb fd 7e bf df ef f7 fb fd 7e bf df ef f7 fb
fd 7e bf df ef f7 3f f8 07 af 29 1d 01

Client only reads 78 9c ed cd 31 11 00 00 08 04 20 cf ef df d9 c5 0e 3a 40 01 before reading new packet of 92, which doesn't exist. Packet not found id: 146.

Style question?

require "HHVMCraft.Core/Networking/Stream.php";
require "HHVMCraft.Core/Helpers/HexDump.php";
require "HHVMCraft.Core/Entities/PlayerEntity.php";
require "HHVMCraft.Core/Windows/InventoryWindow.php";
require "HHVMCraft.Core/Networking/Packets/ChunkPreamblePacket.php";
require "HHVMCraft.Core/Networking/Packets/ChunkDataPacket.php";
require "HHVMCraft.Core/Networking/Packets/DisconnectPacket.php";
require "HHVMCraft.API/Coordinates2D.php";

Any reason why this is here even though composer should be autoloading, also wondering why it's "HHVMCraft.Core" instead of "HHVMCraft\Core".

Just wondering :)

Keep up the good work 👍

Add Buffer Class

Abstract reading/writing to and from buffers.

Should be able to pass in a buffer to be sent over the socket.
Should be able to receive data and put into a buffer.
Read from Buffer in all types.
Write to Buffer in all types.

andrewvy / hhvmcraft Goto Github PK

hhvmcraft's Introduction

Installation?

Why?

Current Progress

Libraries used

hhvmcraft's People

Contributors

Stargazers

Watchers

Forkers

hhvmcraft's Issues

Classes And Namespaces

C-style, C-libraries, but little C-positives?

Required

Packets

breakdown

Recommend Projects

Recommend Topics

Recommend Org