andrewthad / impure-containers

Mutable containers in haskell

impure-containers

Available on hackage.

impure-containers's Issues

Is Maybe.Unsafe robust?

A few years ago I tried to implement the same "nullable" optimized version of Maybe. I used something like the following for null pointers:

data Null = Null

However, when I tried to test this as imported from another package, I ran into mysterious crashes and errors. I assumed that for some reason this "nullable" trick does not work and didn't pursue it further. But I see it here; so my question is: is this robustly usable, and do you have any ideas why my data Null implementation could have possibly crashed?

It is also possible that I simply made some unrelated error in my own attempt, but I recall that I did not think that to be likely.

Implement mapEdges

`Lib` exported

impure-containers/impure-containers.cabal

Line 19 in c930e22

Lib

It's great that you put stuff for others on Hackage, but please, use a bit of time to clean it up :)

Support for multiple edges with same from/to vertex?

I'm wondering whether it would be difficult to add support for multiple edges that go from and to the same vertex. Particularly, I'm interested in knowing how much work it would require to adapt the dijkstra implementation to this.

To be clear, I'm asking about support for a graph that can have two or more edges that all go from some vertex a to some other vertex b (not about support for edges where fromVertex == toVertex). I imagine edges could be deleted selectively by comparing them with their Eq instance (like fgl does: https://www.stackage.org/haddock/lts-11.13/fgl-5.6.0.0/Data-Graph-Inductive-Graph.html#v:delLEdge).

no readme?

In cabal file I see

Please see README.md

but there is no such file in this package.
Is it intended?

Make it possible to lift graph morphism over SomeGraph

`eqsat` issue roundup

I've been using impure-containers in my eqsat project, and I've come up with some issues that you may be interested in. I'm going to comment on this issue with each one, to avoid spamming you. Hackage is sorely lacking a good consistent package for mutable containers, and impure-containers is the best thing I've seen so far :-), so I'd like to see some improvements (and will likely write up PRs after I graduate on May 10).

cc: @chessai

Update container bounds

Juding from the containers package changelog 6.0 should work fine but is currently ruled out by bounds.