Comments (13)
looking into this today i'll let you know if i can find a fix! thanks
from react-native-safari-extension.
can you provide steps to recreate this issue?
from react-native-safari-extension.
I'm facing the same issue
from react-native-safari-extension.
if you could provide a link to a repo or steps to reproduce that would be great.
from react-native-safari-extension.
@robertherber when you commented out CODE_SIGN_ENTITLEMENTS, were you able to successfully build? We shouldn't need an entitlements file in the extension folder (i don't think) so if there's no error, I can just delete the line you commented out.
from react-native-safari-extension.
@andrew-levy Here are repros of both cases:
Original repro - resulting in "***Extension.entitlements" could not be opened. Verify the value of the CODE_SIGN_ENTITLEMENTS build setting for target "***Extension" is correct and that the file exists on disk.
Repro when commenting out - resulting in Signing for "***Extension" requires a development team. Select a development team in the Signing & Capabilities editor.
In both cases just yarn install
and yarn build-local
to reproduce each respective error (I've also tried building with EAS in the cloud - same result). Hope it helps - and let me know if I can help in any other way! 🙂
from react-native-safari-extension.
@robertherber I pulled down your repo and wasn't able to reproduce that error (got an unrelated error that will be addressed in a coming PR). When I comment that line out, I'm able to build successfully, so that makes me think that XCode is automatically adding a development team somehow. Though, when I open the xcode workspace, there is no team selected. The goal is obviously not to open up xcode at all, so ill need to find a way to get around this.
Can you try one thing for me? Instead of commenting that line out, can you change it to this in the patch:
CODE_SIGN_ENTITLEMENTS: `${extensionFolder.replace("Extension", "")}/${extensionFolder.replace("Extension", "")}.entitlements`
This is just a hack right now, but we need to point to the main app's entitlements.
from react-native-safari-extension.
@andrew-levy I get the same error as when commenting it out, i.e.:
Signing for "***Extension" requires a development team. Select a development team in the Signing & Capabilities editor.
I'm guessing it's eas-cli
that doesn't set the development team for extensions for some reason? Curious as how it can work differently in such a barebones repro on our respective machines.
from react-native-safari-extension.
@robertherber
my steps are:
expo init newProject
cd newProject
expo install react-native-safari-extension
expo prebuild -p ios
expo run:ios
with no errors or issues, so I'm not sure exactly why its not working.
I do see this in xcode, but its not making the build fail or anything. Is your checkbox checked by chance?
from react-native-safari-extension.
@andrew-levy Thanks for showing your process. With expo run:ios
I get another error (not sure where it comes from since I have no popup.js in the source):
reproioswebextensionExtension/Resources/popup.js: No such file or directory
Could you try running yarn build-local
on the repro to see if you get the same as me? I guess eas-cli build
and expo run:ios
might behave a bit differently.
from react-native-safari-extension.
Yes, you're getting that error because the project assumes a certain file structure. This is another bug I need to address (and will soon)
I tried running yarn build-local
which fails because I don't have an apple developer account. I have only tested this repo with local builds, not in the cloud unfortunately. Sorry for the bugs, as its still in very early development.
from react-native-safari-extension.
@andrew-levy Thanks for putting this out here, will keep following and help if I can :)
Btw - I spotted this in react-native-app-clip plugin, maybe that could help?
from react-native-safari-extension.
Thanks! yes I based this plugin off of the app clip plugin. I'll have to dig into it more to see what the difference is (i may have missed something)
from react-native-safari-extension.
Related Issues (15)
- small suggestion HOT 1
- This library only supports Expo? HOT 1
- Starting from Xcode 14, resource bundles are signed by default, which requires setting the development team for each resource bundle target. HOT 5
- error: index.js: Cannot find module 'react-native-reanimated/plugin'
- How to access the currently loaded web page from the extension?
- Status of Browser Extension HOT 4
- support messaging between extension and native app? HOT 2
- Provisioning profile "..." doesn't include the aps-environment entitlement. (in target '<my extension'> from project '<my project>' HOT 13
- Bug: "Recovered References" is being added
- Debugging extension documentation is missing HOT 1
- React Native 0.73 support HOT 4
- Enhancement: Reference resource files from a public directory outside of ios/
- Enhancement: Render react app with hot reload HOT 1
- CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler during eas build HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-safari-extension.