Comments (13)
Hey! I'm actively working on the v1
branch which fixes a lot of issues. It's not done yet, but hopefully soon. I remember adding the withRemoveApsEntitlement
part due to another build error, but I will look into this more closely. Thanks for bringing this up.
from react-native-safari-extension.
I appreciate the testing help here! I have one more thing for you to try if you have the time. Try removing line 24 in this file: https://github.com/andrew-levy/react-native-safari-extension/blob/main/plugin/src/xcodeSafariExtension/addXCConfigurationList.ts#L24
CODE_SIGN_ENTITLEMENTS: `${appName}/${appName}.entitlements`,
This is pointing the extension target's entitlements to the parent app's entitlements. I just tried a local and eas build with this line removed, and both succeeded.
from react-native-safari-extension.
No worries!! Awesome, thanks again for your help. I'll push out an update for that later today!
from react-native-safari-extension.
Good to hear! I gave the v1 release a try, but it has the same issue
from react-native-safari-extension.
i’m getting the same error in the v1 release, too, which doesn’t modify the entitlements. When I add withRemoveApsEntitlement
back in, it works. You said it failed for you with and without this line?
from react-native-safari-extension.
Let me try and add it in - I haven't tried modifying anything yet
from react-native-safari-extension.
patching the withRemoveApsEntitlement
back in does not seem to fix it, unfortunately :(
from react-native-safari-extension.
Thanks for checking :/ I'm not able to reproduce it on my end, so I'm not sure what the fix would be. My parent app isnt using push notifications, so that might be why? Will continue to look into this.
from react-native-safari-extension.
I'll see what happens when I remove push notifications from mine
from react-native-safari-extension.
Removing that line does not seem to help unfortunately, but I confirmed that removing expo-notifications allowed it to build correctly
from react-native-safari-extension.
Interesting... I added expo-notifications and enabled push notifications and am seeing it fail with the same error as yours when line 24 is uncommented, and succeeds when its commented out. So it looks like that line has something to do with it. What build command are you running? I'm using npx eas-cli build -p ios --profile
and am using patch-package to make sure the change is being made in the library.
from react-native-safari-extension.
Hey - my bad, it does work! I'd not changed the file structure of the extension after updating to v1, so fixing that (and patching the plugin) worked.
from react-native-safari-extension.
Should be fixed in v1.0.2. Closing!
from react-native-safari-extension.
Related Issues (16)
- small suggestion HOT 1
- Bug: "Recovered References" is being added
- Enhancement: Reference resource files from a public directory outside of ios/
- Enhancement: Render react app with hot reload HOT 1
- Extension.entitlements could not be opened HOT 13
- CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler during eas build HOT 1
- This library only supports Expo? HOT 1
- Starting from Xcode 14, resource bundles are signed by default, which requires setting the development team for each resource bundle target. HOT 5
- error: index.js: Cannot find module 'react-native-reanimated/plugin'
- How to access the currently loaded web page from the extension?
- Status of Browser Extension HOT 4
- support messaging between extension and native app? HOT 2
- Debugging extension documentation is missing HOT 1
- React Native 0.73 support HOT 4
- Update examples to use manifest.json v3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-safari-extension.