andgoldschmidt / derivative Goto Github PK
View Code? Open in Web Editor NEWOptimal numerical differentiation of noisy time series data in python.
Home Page: https://derivative.readthedocs.io/en/latest/
License: Other
Optimal numerical differentiation of noisy time series data in python.
Home Page: https://derivative.readthedocs.io/en/latest/
License: Other
Some derivative methods smooth the coordinate points while calculating the derivatives, and these smoothed coordinates can be useful for SINDy. I think the list of methods that smooth coordinates are:
There's several options for the interface, either
x, x_dot
from Derivative.compute_for()
and Derivative.d()
, and possibly dxdt()
.Derivative.x
set when calling Derivative.compute_for()
. Subclasses that do not smooth x
should probably still set the value to maintain interface. Could be set in Derivative._global()
, but not sure how to deal with savitsky golay, since local methods don't need to compute the derivative for all points.As I see it, the pros/cons boil down to explicit is better than implicit for the functional pattern vs backwards compatibility for the object-oriented pattern. Setting a new object attribute after initialization is implicit, changing return type is explicit. The object oriented pattern requires derivative objects remain public, and users like pysindy would need a more complicated calling convention.
return dxdt(x, t, axis=0, **self.kwargs)
in favor of
deriv = derivative.methods[kind](**self.kwargs)
x_dot = deriv.d(x, t, axis)
x = deriv.x
return x, x_dot
That said, backwards compatibility is always important. I'm happy to build a PR of either.
Hey @andgoldschmidt , what are your thoughts about moving away from poetry? At the very least, .gitignoring poetry.lock would prevent all the dependabot PRs that deal with dependencies of dependencies. Thanks to #14, I only use poetry as a backend on this project (and pip, venv for the rest). There are two (related) suggestions in line with removing the poetry backend. (a) changing pyproject.toml project data to the format in PEP 621 and (b) changing the backend to setuptools_scm instead of poetry.core. The former adds flexibility for different backends, and the latter allows removing all the version strings in the code and extracting version information from git tags.
Relevant SO question
I understand this is very much a matter of personal workflows and preference, so I don't want to take a strong position on the toml stuff. But definitely recommend discarding poetry.lock in the git repo to limit the dependabot.
It is typical to package a license file with the distributed source code. It would be helpful for downstream packaging, for example.
Hi there, great library. Are you thinking of adding support for multivariate data at all?
The current package produces derivatives methods for time series.
All the methods included here can be extended to apply to spatial derivatives of arbitrary dimension.
There is no current timeline for adding this feature.
The project should have issues templates.
I noticed compare()
doesn't assert the numerics, it just issues a warning. All tests currently pass with the change to assert, so I assume it's OK to submit a PR that would make them assert? It would be helpful to have this in place when changing the repo for #15.
I noticed #15 was causing issues with x
having multiple time series (e.g. x.shape==(2,100)
), so also added some tests. Some existing methods fail on either the median or residual tests even when they pass on the individual series.
EDIT: Solved, it was for very aperiodic tests and spectral derivatives.
That brings up another question: Is there a reason to test median and standard deviation of the residual, instead of inf norm, MAE, MSE?
EDIT: Okay, ran a lot of tests and median seems better than 1-norm/MAE for variable numbers of timepoints.
I noticed that the default value for axis
throughout derivative.py
is 1. What's the rationale for using 1 instead of 0? The only reason I ask is because we've got to set axis=0
when using derivative
objects in PySINDy (to conform to sklearn's conventions and those in the original SINDy paper, the 0 axis corresponds to time and the 1 axis to features).
Current build config does not re-run the example jupyter notebook when building docs (It was causing an error that RTD ignores, see #30). This means the results from running notebook examples are no longer viewable in the docs, so this should be restored / the RTD error addressed or an alternative workflow should be introduced.
Model the data as a sparse linear combination of wavelets and compute the derivative of the wavelet basis.
Might consider using SURE shrinkage from Donoho, D. L. and Johnstone, I. M. for the fit with some modifications to compute derivatives. Other options include skimage or pywavelets packages.
The most recent build of docs failed after PR #46, with the warning:
We encountered a problem with a command while building your project. To resolve this error, double check your project configuration and installed dependencies are correct and have not changed recently.
Pertaining to this issue,
While trying to differentiate an array with len(X.shape) = 3
, for example X.shape = (10, 100, 2)
and t = np.arange(0, 10, 0.1)
, since X is not 2-dimensional, I get the error "Invalid Shape of X".
Without having to manipulate the shape of X, is it possible to implement differentiation of multidimensional arrays?
The functions should allow differentiation methods to accept a "periodic" flag that changes the boundary conditions used by a given method to periodic.
A pad for "mirror" boundaries may also be easy to add.
One possible solution is to add padding functions to the utilities (utils.py). In some of the global methods, it's not clear what the definition of a periodic boundary should be.
Hey Andy, I've been trying out a few hyper-parameter optimization methods for Kalman smoothing from recent papers. While this isn't as established as the main methods of derivative
, I'd love to be able to rely on this package for the main Kalman parts.
It feels like this would be best as an entry point. Entry points are a form of Dependency Inversion. That way, users (like me) could write the hyperparameter optimization code in a somewhat throw-away fashion, and derivative
could call that code with only a few generic lines added to this package. No need to review code or determine whether an algorithm meets some acceptability criteria.
Not sure if you've grappled with this kind of a programming problem or architecture in the past, but I could draft a quick PR to show how it works?
Hey Andy, I'm trying to bump the requirement specifier for pysindy
and looking for the first release that has a particular code change. The git repo only has tags for 0.3.1 and 0.4.2. Not sure what your release workflow is, but could you add a git tag when you release?
From differentiation.dxdt
:
An empty X results in an empty derivative.
In the interest of ZOP #10, Errors should never pass silently, should dxdt()
instead raise an error? It feels like returning an empty array instead of failing is an attempt to be cleverly helpful, but beyond the remit of these functions. Callers IMO should be responsible for the
if x.size:
x_dot = dxdt(...)
Noticed when delving into an error in Derivative.x()
in #15. I was refactoring the shape manipulation to be used by both x()
and d()
, and it gets (minorly) more verbose when handling empty arrays.
To add backwards compatibility with derivative.py, a function-style api should be implemented on top of this project's derivative interface.
E.g. from derivative.py/derivative/derivative.py on 05/04/2020:
methods = {}
def register(name=""):
def inner(f):
n = name or f.__name__
methods[n] = f
return f
return inner
from .loc import *
from .glob import *
def derivative(x, y, kind="finitediff", **kwargs):
method = methods.get(kind)
f = lambda y: method(x, y, **kwargs)
if len(y.shape) > 1:
return np.apply_along_axis(f, 0, y)
else:
return f(y)
Hey Andy, ๐, I'm starting to work on the Kalman stuff and trying to make sure the docs build correctly. Apparently, poetry automatically installs the dev dependencies but not optional dependencies which must be specified individually. Can I copy all the documentation optional dependencies into the [tool.poetry.dev-dependencies]
section of pyroject.toml?
Related: I can't build the docs even with the optional dependencies: mention this in #12.
Also, I have no idea why my /env/ folder isn't showing up since there's no .gitignore to ignore it, but maybe some poetry magic?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.