ancho85 / pylint-playero-plugin

A plugin for pylint to work with Playero ERP

pylint-playero-plugin

About

pylint-playero-plugin is a Pylint plugin for improving code analysis for when analysing code using Playero ERP.

Usage

Pylint

Ensure pylint-playero-plugin is installed and on your path, and then run pylint:

pylint --load-plugins Playero [..other options..]

Read the wiki for usage with SublimeText

Features

• Prevents warnings and errors about Playero-generated attributes, classes, methods. (Now fully supported)
• Xml record file parsing to get attributes of a table/class.
• Py file parsing to get methods, functions and attributes of a class.
• Inheritance is generated based on Playero's xml settings file.
• built-in methods, functions and attributes accepted. (Now fully supported)
• SuperClass generation.
• NewRecord, NewReport, NewWindow generation.
• Query parsing and checking for syntax

License

pylint-playero-plugin is available under the GPLv2 license.

Required

• logilab-common==0.61.0
• astroid==1.1.1
• pylint-1.0.0

Required to check mysql syntax:

• pyparsing-2.0.2
• MySQL-python-1.2.5

pylint-playero-plugin's Issues

Improve findPaths()

the search of paths is actually very difficult to understand. Must be refactored and divided in minor sub functions

refactor directory structure

create a pylint_playero directory and move everything inside it, leaving outside of this directory all those files not related with the plugin itself, as .gitignore, License and README.md
This will be done for properly use an import system based on pylint_playero namespace, which currently cannot be done due to the "-" in the plugin's folder name.
Take as reference pylint_django directory structure

speed up

takes a lot of time to finish. Even with the use of @cache.store as decorator there must be a way to speed things up. Check profile results.

submit project to pypi

read this guide or any other to share a stable version, maybe after milestone 1.0.0

classes are built based on xml files only

classes_transform calls findPaths, which locates in the "interface" directory only.
If not found, then no functionality is available.

Example: CreditLimitUpdate.py in extra/Flota/routines

Inference error in relative imports

seen in EmployeeDataReport.py

from dateutil.relativedelta import *

Classes' attribute analysis fails when that attribute is assigned anywhere in the code

If an attribute is accessed only to be read, all is ok. But is that attribute is somehow written, an error happens in astroid: 'dict' has no attribute 'append'

from OpenOrange import *

ParentStock = SuperClass("Stock", "Record", __file__)
class Stock(ParentStock):

    pass


from StockSettings import StockSettings
ss = StockSettings.bring()
Stock.allowInvertedStockValues = ss.AllowInvertedStockValues #PROBLEM HERE

cannot import classes defined inside other classes (Row instances)

pylint init-hook includes all workspace paths defined in config/playero.cfg
In the same file is defined 2 classes. Invoice.py

from Invoice import Invoice #works
from Invoice import InvoiceItemRow #works
from InvoiceItemRow import InvoiceItemRow  #Does not work.

It also should work as last line is defined

SAXParseException Duplicate Attribute

SAXParseException Duplicate Attribute with RepairSettings.record.xml
enable "extra/Repair"

Multiple level of inheritance are not inferred correctly

Enabling a higher level of inheritance causes that methods and attributes from given class not be correctly generated.
Example:

  <scriptdir level="4" path="extra/Flota" />
  <scriptdir level="5" path="extra/GasStation" />
  <scriptdir level="6" path="extra/GestionSensitive" />

from Invoice import Invoice
Invoice.bring(1)

Class 'Invoice' has no 'bring' member

BulkEntry inheritance issues with ExtraItem field

Key error with detail field "ExtraItem" on BulkEntry class.

build and parse exec statements

try to parse and build import statements:

exec("from %s import %s as theRecord" % (rows.Type, rows.Type))
exec("from %sWindow import %sWindow as theWindow" % (rows.Type, rows.Type))
ther = theRecord.bring(rows.SerNr)
if ther:
    window = theWindow()
    window.setRecord(ther)
    window.open() 

Also assignments statements:

exec("curRowValue = rec.%s[rownr]" % fieldname)
exec("rowObjList = rec.%s" % fieldname) 

Instantiators' date attributes must not be strings

Instantiators' date attributes must not be strings, strings doesn't have date methods and attributes and lines like the one below throws an exception:

rec.TransDate.strftime("%d/%m/%Y")

query checker getHeirValue doesn't find current name created in queryTxt

def repla(txt):
  txt = txt.replace(":1", "Table")
  return txt

query7 = self.getQuery()
query7.sql = repla(query7.sql)
query7.open()

getQuery is inherited and the visitors create a queryTxt key, but the created key is "query", and then, getHeirValue checks for "is query7 in queryTxt?".

xmlfields replace all iterators on getRecord instanciator

xmlfields replace all iterators on getRecord instanciator. Can be seen with CupoDeactivation when trying to iterate over a detail's getRecord instance.

build and parse Query objects

the built-in object Query and the primary attribute "sql" must be created and parsed in order to detect possible query syntax errors

high memory usage when analysing multiple targets at once

when using generalTest.py a great amount of memory is used by python.

Transaction's buildRecordModule throws AttributeError when pylinting

"AttributeError: 'int' object has no attribute 'statement'
On Transaction.py pylint process, buildRecordModule on

class Transaction(object):
    Origin = {}
    Origin["SalesOrder"] = 0 #LINE THROWING THE PROBLEM

Playero.py's plugin issue detected at buildRecordModule function:

module.locals.update([(attrs, {0:None}) for attrs in attributes if not attrs.startswith("_")])

Document classes and inheritance wouldn't build

Currently there are no way to guess the type of class, only by the xml file, so, when a document is being builded all the inheritance, methods and attributes are skipped.
Example: SAGEProcess branch

CredLimit has no attribute store() nor save()

find out why the buildInstantiator is not getting all attributes and methods for this class. Maybe the inheritance simulation built in the class has some to do with it.

plugin should not apply to itself

When pylinting files inside "playero" workspace it's ok to use this plugin. But other files outside path's definition (playero.cfg) should be ignored and pylint them with basics only

fix Documents and Windows inheritance

SuperClass is called inside documents and Window classes, some of them will never have a record.xml associated.

add coveralls.io support

coveralls.io branch created