Coder Social home page Coder Social logo

Comments (5)

uhermjakob avatar uhermjakob commented on July 23, 2024

Good point. In a sense, there are really two levels of monetary quantities:
(1) a precise monetary-quantity with a specific :quant and a specific :value
Example: $5 (m / monetary-quantity :quant 5 :unit (d / dollar))
(2) A larger semantic class of monetary quantities.
Example: approximately $5, a lot of money, the amount spent on advertising

One solution:
Introduce semantic classes class-monetary-quantity, class-temporal-quantity, ...
and use them as a special NE-type instead of "thing". But in cases such as
(a / approximately :op1 (m / monetary-quantity :quant 5 :unit (d / dollar)))
where both "a" and "m" are of class class-monetary-quantity, we don't make
any changes, relying instead on tools TBD that can automatically determine
such a semantic class.
Conversely, we might use monetary-quantity and specific-monetary-quantity,
but I'm hesitant to make a change that would require massive changes to our AMR Bank.

from amr-guidelines.

nschneid avatar nschneid commented on July 23, 2024

@ULFULF: What's wrong with using monetary-quantity for both precise and imprecise amounts? Would it be sufficient to define your class (1) as monetary-quantities with a :quant and :unit?

from amr-guidelines.

uhermjakob avatar uhermjakob commented on July 23, 2024

@nschneid: Pragmatic reasons. More lenient typing would make it much harder for the AMR Checker to catch errors. It would probably also make it a bit harder to make a clear case how fuzzy quantities (such as "about $5") are built based on precise quantities, top-modified by fuzzy operators such as between and approximately.

from amr-guidelines.

cbonial avatar cbonial commented on July 23, 2024

I think that it's easy enough for annotators to recognize the distinction that we could use something like class-monetary quantity as an entity type and also know when to use the actual monetary-quantity. I actually like the "class" terminology and think this reinforces the distinction.

from amr-guidelines.

kevincrawfordknight avatar kevincrawfordknight commented on July 23, 2024

feel free to use:

(m2 / maintain-01
:arg1 (m / monetary-quantity
:arg3-of (s / spend-01 ...)))

instead of:

(m2 / maintain-01
:arg1 (t / thing
:arg3-of (s / spend-01 ...)))

(m2 / maintain-01
:arg1 (s / spend-01 ...))

from amr-guidelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.