Coder Social home page Coder Social logo

ampersand-checkbox-view's People

Contributors

alexgoldovsky avatar bear avatar bryanspears avatar cdaringe avatar dhritzkiv avatar henrikjoreteg avatar imorrison avatar klaemo avatar latentflip avatar lukekarrys avatar mikehedman avatar pgilad avatar sethlivingston avatar wraithgar avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ampersand-checkbox-view's Issues

Use props and bindings

Since we're extending View, any reason we're not using props for the settings and bindings to set the label text content inside the label element? It would make this element more extendable. I can help with the PR if you agree.

template not extendable

problem statement

CheckboxView.extend({
    template: ...
})

does not work.

solution

  • move template into the default view def
  • update initialize()

Remove "type" property from README

I'm pretty sure this is just a copy/paste error:

// type value to use for the input tag's type value
type: 'text',

This property is never used in the view since it is, of necessity, hardcoded to "checkbox".

Support disabled attribute

It should be possible to make a checkbox disabled. Is there a reason for this one to not include that? Or just missing?

Enter key propagation

On enter the checkbox is checked and the form is submitted.
Maybe not propagating the enter key is more suitable, enter on an input should submit the form but not on a checkbox? Don't you think?

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.