amigrave / git-qdiff Goto Github PK

Hi!
Nice work, looks good and it is a nice help.

I would like to suggest to add a little reminder to the documentation (e.g. to the README file):

Remember to previously run the command:
bzr whoami "Your Name <[email protected]>"

Right after installing, I tried git qdiff and forgot to previously run bzr whoami (just not using my usual laptop) and I got an error. Nothing critical or complicated, but ugly anyways:

git qdiff
bzr: ERROR: Unable to determine your name.
Please, set your name with the 'whoami' command.
E.g. bzr whoami "Your Name [email protected]"
Traceback (most recent call last):
File "/usr/local/bin/git-qdiff", line 7, in
sys.exit(git_qdiff.main())
File "/usr/local/lib/python2.7/dist-packages/git_qdiff.py", line 54, in main
qdiff(left, right)
File "/usr/local/lib/python2.7/dist-packages/git_qdiff.py", line 16, in qdiff
subprocess.check_call(['bzr', 'commit', '-qmm'])
File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['bzr', 'commit', '-qmm']' returned non-zero exit status 3
/usr/lib/git-core/git-difftool line 464: No existe el archivo o el directorio
git failed with returncode 1

On a fresh install on macbook air mavericks, git-qdiff crashes with this error:

invalid literal for int() with base 10: 'Git-48)'

using the tig integration, git-qdiff doesn't work on the unstaged changes line of the tig's log view

when using git-qdiff on commit that only adds files, the program crashes with this traceback:

Traceback (most recent call last):
  File "/usr/local/bin/git-qdiff", line 7, in <module>
    sys.exit(git_qdiff.main())
  File "/usr/local/lib/python2.7/site-packages/git_qdiff.py", line 55, in main
    qdiff(left, right)
  File "/usr/local/lib/python2.7/site-packages/git_qdiff.py", line 17, in qdiff
    subprocess.check_call(['bzr', 'commit', '-qmm'])
  File "/usr/local/Cellar/python/2.7.8_1/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['bzr', 'commit', '-qmm']' returned non-zero exit status 3
/usr/local/Cellar/git/2.0.0/libexec/git-core/git-difftool line 464: No such file or directory
git failed with returncode 1

otherwise bazaar.conf is automatically updated